Bug 231940

Summary: FunctionDispatcher should not be RefCounted
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: Web Template FrameworkAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cgarcia, cmarcelo, ews-watchlist, kkinnunen, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231939
https://bugs.webkit.org/show_bug.cgi?id=231897
Bug Depends on:    
Bug Blocks: 238863    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
[fast-cq] For landing none

Description Kimmo Kinnunen 2021-10-19 00:10:09 PDT 
FunctionDispatcher should not be RefCounted.
There's nothing inherently refcounted about being recipient of task submissions.

FunctionDispatcher being RefCounted lead to fix bug 231897 using this as the solution, where the original bug was bug 231897
Comment 1 Kimmo Kinnunen 2021-10-19 00:12:08 PDT 
.. where the original bug was 231939
Comment 2 Radar WebKit Bug Importer 2021-10-26 00:11:18 PDT 
<rdar://problem/84650931>
Comment 3 Kimmo Kinnunen 2022-04-06 04:30:20 PDT 
Created attachment 456808 [details]
Patch
Comment 4 Kimmo Kinnunen 2022-04-06 12:00:21 PDT 
Created attachment 456844 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-04-06 12:33:58 PDT 
Created attachment 456847 [details]
Patch
Comment 6 Chris Dumez 2022-04-06 12:37:07 PDT 
Comment on attachment 456847 [details]
Patch

r=me
Comment 7 Kimmo Kinnunen 2022-04-06 12:40:08 PDT 
Created attachment 456851 [details]
Patch
Comment 8 Kimmo Kinnunen 2022-04-06 12:50:14 PDT 
Comment on attachment 456851 [details]
Patch

Thanks! (removing r?, will upload for landing tomorrow)
Comment 9 Kimmo Kinnunen 2022-04-06 22:40:00 PDT 
Created attachment 456891 [details]
Patch
Comment 10 EWS 2022-04-11 05:58:06 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 11 Kimmo Kinnunen 2022-04-12 02:41:45 PDT 
Created attachment 457320 [details]
[fast-cq] For landing
Comment 12 EWS 2022-04-12 02:45:05 PDT 
Committed r292768 (249552@main): <https://commits.webkit.org/249552@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457320 [details].