| Summary: | WebPDFViewPlaceholder should use a weak delegate | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=231956 | ||||||
| Attachments: |
|
||||||
|
Description
David Kilzer (:ddkilzer)
2021-10-18 18:00:18 PDT
Created attachment 441665 [details]
Patch v1
Comment on attachment 441665 [details]
Patch v1
Marking cq+ since ios-wk2 won't test this (this affects iOS WK1), and api-ios may not test it either (I don't see any WK1 PDF tests in Tools/TestWebKitAPI/Tests).
Both bots are also 8 or 24 hours behind, and any behavior change here would be changing a flakey crashing test into a flakey failing test, so this would likely only need a test expectation update.
Committed r284559 (243301@main): <https://commits.webkit.org/243301@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441665 [details]. |