Bug 231925 – [EWS] Move EWS bots to iOS 15 / watchOS 8 / tvOS 15

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryan Haddad]

[EWS] Move EWS bots to iOS 15 / watchOS 8 / tvOS 15

[Ryan Haddad]

Created attachment 441664 [details]
Patch

[Ryan Haddad]

PR: https://github.com/ryanhaddad/WebKit/pull/new/eng/ews-ios15

[Aakash Jain]

Comment on attachment 441664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441664&action=review

> Tools/CISupport/ews-build/config.json:121
> +      "name": "iOS-15-Build-EWS", "shortname": "ios", "icon": "buildOnly",

I have wondered few times if it would be better to keep generic builder names like 'iOS-Build-EWS' instead of 'iOS-14-Build-EWS'. I don't have any major reasoning for deciding either way. Few points below.

Without the OS version in the name:
- We would have one less thing to update in our configuration.
- Buildbot wouldn't create new builder, maybe in very long term it might result in slightly better performance because of not having too many "old builders". 
- Switching to new queues will be smoother, since there wouldn't be any remaining pending builds on old queues after moving bots to new queues.
- 'Retry failed builds' button will still work for builds prior to moving the bots to newer OS (that's a very corner case in which 'Retry failed builds' button simply try to retry the failed build on old builder, but since there is no bot on old builder to process it, so it never gets retried).

One small reasoning for keeping the OS version in name can be that it makes it very obvious which OS we are running on each queue, both in buildbot and in status-bubbles. However, we display the OS and Xcode information through the PrintConfiguration step in every build in buildbot, and the same information is also displayed in status bubbles hover-over message.

Thoughts?

[Ryan Haddad]

I think that removing the OS version from the name would be OK if we bubbled up the iOS/watchOS/tvOS version in the status bubbles and the printed configuration. I don't expect developers to be able to immediately correlate Xcode version with the particular simulator version being tested.

[Aakash Jain]

(In reply to Ryan Haddad from comment #4)
> I think that removing the OS version from the name would be OK if we bubbled up the iOS/watchOS/tvOS version in the status bubbles and the printed configuration.
Yeah, we already do that. For example hover over any iOS/watchOS/tvOS status-bubble on the patch on this bug.

[Ryan Haddad]

Created attachment 441743 [details]
Patch

[Ryan Haddad]

(In reply to Aakash Jain from comment #5)
> (In reply to Ryan Haddad from comment #4)
> > I think that removing the OS version from the name would be OK if we bubbled up the iOS/watchOS/tvOS version in the status bubbles and the printed configuration.
> Yeah, we already do that. For example hover over any iOS/watchOS/tvOS
> status-bubble on the patch on this bug.
I only see the macOS version and the Xcode version.

[Aakash Jain]

(In reply to Ryan Haddad from comment #7)
> I only see the macOS version and the Xcode version.
You are right, I misread your previous comment. 
That would be a larger effort to bubble up the iOS/watchOS/tvOS version, so let's leave that for now.

[Ryan Haddad]

Created attachment 441785 [details]
[fast-cq] Patch

[EWS]

Committed r284492 (243246@main): <https://commits.webkit.org/243246@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441785 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84430972>