Bug 23191

Summary:

Add the first pieces of platform/graphics/skia

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Add the first few files from platform/graphics/skia	none
Add two more files for platform/graphics/skia.	none
Add a cleaned-up GraphicsContextSkia implementation to WebKit	none
Add ImageBufferSkia and ImageSkia files.	none

Description Eric Seidel (no email) 2009-01-08 10:52:04 PST

Add the first pieces of platform/graphics/skia

In order to expedite the process of up-streaming, Dimitri and I are pair-programming today.  We're scrubbing all the platform/graphics/skia files locally, committing them to the Chrome tree, and then posting them here and landing them in the WebKit tree.  I'm not requesting a second review, since I've already reviewed them as Dimitri has been typing, but I'm posting the patches here for completeness.

Comment 1 Eric Seidel (no email) 2009-01-08 10:56:54 PST

Created attachment 26528 [details]
        Add the first few files from platform/graphics/skia

 WebCore/ChangeLog                                  |   48 ++++
 .../graphics/skia/BitmapImageSingleFrameSkia.h     |   62 +++++
 WebCore/platform/graphics/skia/FloatPointSkia.cpp  |   47 ++++
 WebCore/platform/graphics/skia/FloatRectSkia.cpp   |   46 ++++
 WebCore/platform/graphics/skia/IntPointSkia.cpp    |   50 ++++
 WebCore/platform/graphics/skia/IntRectSkia.cpp     |   54 +++++
 WebCore/platform/graphics/skia/SkiaUtils.cpp       |  240 ++++++++++++++++++++
 WebCore/platform/graphics/skia/SkiaUtils.h         |   64 ++++++
 8 files changed, 611 insertions(+), 0 deletions(-)

Comment 2 Eric Seidel (no email) 2009-01-08 10:59:02 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h
	A	WebCore/platform/graphics/skia/FloatPointSkia.cpp
	A	WebCore/platform/graphics/skia/FloatRectSkia.cpp
	A	WebCore/platform/graphics/skia/IntPointSkia.cpp
	A	WebCore/platform/graphics/skia/IntRectSkia.cpp
	A	WebCore/platform/graphics/skia/SkiaUtils.cpp
	A	WebCore/platform/graphics/skia/SkiaUtils.h
Committed r39712

Comment 3 Eric Seidel (no email) 2009-01-08 11:46:19 PST

Commit the right set of files the second time!

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h
	M	WebCore/platform/graphics/skia/FloatPointSkia.cpp
	M	WebCore/platform/graphics/skia/FloatRectSkia.cpp
	M	WebCore/platform/graphics/skia/IntPointSkia.cpp
	M	WebCore/platform/graphics/skia/IntRectSkia.cpp
	M	WebCore/platform/graphics/skia/SkiaUtils.cpp
	M	WebCore/platform/graphics/skia/SkiaUtils.h
Committed r39713

Comment 4 Eric Seidel (no email) 2009-01-08 13:46:05 PST

Created attachment 26532 [details]
Add two more files for platform/graphics/skia.

 WebCore/ChangeLog                                  |   20 +++
 WebCore/platform/graphics/skia/GradientSkia.cpp    |  164 ++++++++++++++++++++
 .../graphics/skia/GraphicsContextPlatformPrivate.h |   55 +++++++
 3 files changed, 239 insertions(+), 0 deletions(-)

Comment 5 Eric Seidel (no email) 2009-01-08 13:51:51 PST

Second round:
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/platform/graphics/skia/GradientSkia.cpp
	A	WebCore/platform/graphics/skia/GraphicsContextPlatformPrivate.h
Committed r39718

(This time I even committed the right files!)

Comment 6 Eric Seidel (no email) 2009-01-08 14:05:43 PST

Created attachment 26533 [details]
Add a cleaned-up GraphicsContextSkia implementation to WebKit

 WebCore/ChangeLog                                  |   61 ++
 .../platform/graphics/skia/GraphicsContextSkia.cpp | 1122 ++++++++++++++++++++
 2 files changed, 1183 insertions(+), 0 deletions(-)

Comment 7 Eric Seidel (no email) 2009-01-08 14:06:56 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Committed r39719

I think it's time to retire this bug.  I'll open a new one for the next set of upstream changes.

Comment 8 Eric Seidel (no email) 2009-01-08 16:40:18 PST

Created attachment 26545 [details]
Add ImageBufferSkia and ImageSkia files.

2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add ImageBufferSkia and ImageSkia files.
        https://bugs.webkit.org/show_bug.cgi?id=23200
        For now we've left BitmapImage and BitmapImageSingleFrameSkia
        implementations in the ImageSkia file (like ImageCG has), but
        we intend to break them out into their own files.

        * platform/graphics/skia/ImageBufferSkia.cpp: Added.
        (WebCore::ImageBufferData::ImageBufferData):
        (WebCore::ImageBuffer::ImageBuffer):
        (WebCore::ImageBuffer::~ImageBuffer):
        (WebCore::ImageBuffer::context):
        (WebCore::ImageBuffer::image):
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/skia/ImageSkia.cpp: Added.
        (WebCore::):
        (WebCore::FrameData::clear):
        (WebCore::Image::loadPlatformResource):
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        (WebCore::BitmapImage::checkForSolidColor):
        (WebCore::BitmapImage::draw):
        (WebCore::BitmapImageSingleFrameSkia::draw):
        (WebCore::BitmapImageSingleFrameSkia::create):
---
 WebCore/ChangeLog                                  |   31 ++
 WebCore/platform/graphics/skia/ImageBufferSkia.cpp |  210 +++++++++
 WebCore/platform/graphics/skia/ImageSkia.cpp       |  458 ++++++++++++++++++++
 3 files changed, 699 insertions(+), 0 deletions(-)