Bug 231902

Summary:

Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext()

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

213673

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2021-10-18 09:46:17 PDT

Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext().

Found by clang static analyzer.

Comment 1 Radar WebKit Bug Importer 2021-10-18 09:46:28 PDT

<rdar://problem/84375203>

Comment 2 David Kilzer (:ddkilzer) 2021-10-18 09:49:02 PDT

Created attachment 441619 [details]
Patch v1

Comment 3 Wenson Hsieh 2021-10-18 09:50:02 PDT

Comment on attachment 441619 [details]
Patch v1

Good catch!

r=mews

Comment 4 David Kilzer (:ddkilzer) 2021-10-19 12:52:28 PDT

Comment on attachment 441619 [details]
Patch v1

Took a little over a day, but everything is green now, so adding cq+.

Comment 5 EWS 2021-10-19 12:56:20 PDT

Committed r284481 (243240@main): <https://commits.webkit.org/243240@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441619 [details].