Bug 231890

Summary: Close peer connection sockets when entering page cache
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2021-10-18 02:41:27 PDT
Close peer connection sockets when entering page cache
Attachments
Patch (4.65 KB, patch)
2021-10-18 02:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (6.13 KB, patch)
2021-10-18 04:53 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.45 KB, patch)
2021-10-19 01:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-10-18 02:49:03 PDT
Created attachment 441577 [details] Patch
youenn fablet
Comment 2 2021-10-18 04:53:55 PDT
Created attachment 441586 [details] Patch
Eric Carlson
Comment 3 2021-10-18 08:49:02 PDT
Comment on attachment 441586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441586&action=review > LayoutTests/webrtc/datachannel/datachannel-page-cache-send.html:37 > + waitForConnectionState(pc1.connectionState, "disconnected"); Should this be `await waitForConnectionState(pc1.connectionState, "disconnected")` ?
youenn fablet
Comment 4 2021-10-19 01:00:16 PDT
Created attachment 441697 [details] Patch for landing
EWS
Comment 5 2021-10-19 04:03:22 PDT
Committed r284442 (243204@main): <https://commits.webkit.org/243204@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441697 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-19 04:04:17 PDT
<rdar://problem/84409480>
Note You need to log in before you can comment on or make changes to this bug.