Bug 231881

Summary: overriding RTCVideoDecoderH264/265 color space attachments not always done
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: WebRTCAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, osvaldo.rivera1994, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Cameron McCormack (:heycam) 2021-10-17 14:33:29 PDT 
I found that in some configurations, e.g. builds on Catalina, the "ColorInfoGuessedBy" attachment is not placed on CVPixelBuffers we get from the VTDecompressionSession, but the guessed, incorrect color space attachments are still there. Since we are currently only supporting sRGB color space video streams in WebRTC, we shouldn't check for "ColorInfoGuessedBy", and instead always override the attachments.
Comment 1 Radar WebKit Bug Importer 2021-10-17 14:33:56 PDT 
<rdar://problem/84350707>
Comment 2 Cameron McCormack (:heycam) 2021-10-17 14:35:45 PDT 
Created attachment 441551 [details]
Patch
Comment 3 EWS 2021-10-18 20:43:23 PDT 
Committed r284433 (243195@main): <https://commits.webkit.org/243195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441551 [details].