Bug 231881

Summary: overriding RTCVideoDecoderH264/265 color space attachments not always done
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: WebRTCAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, osvaldo.rivera1994, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2021-10-17 14:33:29 PDT
I found that in some configurations, e.g. builds on Catalina, the "ColorInfoGuessedBy" attachment is not placed on CVPixelBuffers we get from the VTDecompressionSession, but the guessed, incorrect color space attachments are still there. Since we are currently only supporting sRGB color space video streams in WebRTC, we shouldn't check for "ColorInfoGuessedBy", and instead always override the attachments.
Attachments
Patch (4.72 KB, patch)
2021-10-17 14:35 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-17 14:33:56 PDT
<rdar://problem/84350707>
Cameron McCormack (:heycam)
Comment 2 2021-10-17 14:35:45 PDT
Created attachment 441551 [details] Patch
EWS
Comment 3 2021-10-18 20:43:23 PDT
Committed r284433 (243195@main): <https://commits.webkit.org/243195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441551 [details].
Note You need to log in before you can comment on or make changes to this bug.