Bug 231858

Summary: Use inline iterator for SVG reverse BiDI reordering
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, Hironori.Fujii, kondapallykalyan, mmaxfield, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Antti Koivisto 2021-10-15 23:15:01 PDT
it doesn't need to be generic.
Comment 1 Antti Koivisto 2021-10-15 23:19:27 PDT
Created attachment 441478 [details]
Patch
Comment 2 Antti Koivisto 2021-10-16 00:27:16 PDT
Created attachment 441480 [details]
Patch
Comment 3 EWS 2021-10-16 05:39:44 PDT
Committed r284315 (243111@main): <https://commits.webkit.org/243111@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441480 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-16 05:40:16 PDT
<rdar://problem/84331836>
Comment 5 Fujii Hironori 2021-10-19 18:44:53 PDT
Comment on attachment 441480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441480&action=review

> Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h:76
> +    if (line->containingBlock().style().rtlOrdering() == Order::Visual)

This breaks PlayStation port. See Bug 231923.