Bug 231834

Summary: [WebAuthn] Many Objective-C classes leak their instance variables
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, katherine_cheney, kkinnunen, pascoe, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2021-10-15 14:35:47 PDT 
Many Objective-C classes used by WebAuthn leak their instance variables due to missing -dealloc methods that release the instance variables.

Found by the clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2021-10-15 14:36:06 PDT 
<rdar://problem/84317190>
Comment 2 David Kilzer (:ddkilzer) 2021-10-15 14:41:29 PDT 
Created attachment 441429 [details]
Patch v1
Comment 3 Brent Fulgham 2021-10-15 14:55:49 PDT 
Comment on attachment 441429 [details]
Patch v1

Oh, boy. Thank you for finding these. r=me.
Comment 4 David Kilzer (:ddkilzer) 2021-10-16 20:39:32 PDT 
Comment on attachment 441429 [details]
Patch v1

Marking cq+ because api-ios failures happen with and without the patch:

Failures in API Test first run: ['TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia', 'TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS', 'TestWebKitAPI.WebKitLegacy.PreemptVideoFullscreen']
Failures in API Test second run: ['TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia', 'TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS', 'TestWebKitAPI.WebKitLegacy.PreemptVideoFullscreen']
Flaky Tests: 
Failures in API Test on clean tree: 
New failures: TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia, TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS, TestWebKitAPI.WebKitLegacy.PreemptVideoFullscreen

Not sure why the bots flagged this as a regression, though.
Comment 5 David Kilzer (:ddkilzer) 2021-10-16 20:39:51 PDT 
The api-gtk failures are also unrelated.
Comment 6 EWS 2021-10-16 21:03:29 PDT 
Committed r284331 (243126@main): <https://commits.webkit.org/243126@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441429 [details].