Bug 231830

Summary: _WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web InspectorAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2021-10-15 14:06:43 PDT 
_WKRemoteWebInspectorViewController leaks its instance variables and should use a weak delegate.

Leaks found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2021-10-15 14:07:02 PDT 
<rdar://problem/84316056>
Comment 2 David Kilzer (:ddkilzer) 2021-10-15 14:16:05 PDT 
Created attachment 441426 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2021-10-15 14:27:36 PDT 
Comment on attachment 441426 [details]
Patch v1

Oops, didn't see the implementation of -webView and -window.
Comment 4 David Kilzer (:ddkilzer) 2021-10-15 14:29:49 PDT 
Created attachment 441428 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2021-10-16 20:37:58 PDT 
Comment on attachment 441428 [details]
Patch v2

Adding cq+ since api-gtk failures are unrelated.
Comment 6 EWS 2021-10-16 20:58:59 PDT 
Committed r284329 (243124@main): <https://commits.webkit.org/243124@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441428 [details].