[CURL] POST without body becomes GET

• Component: Platform
• Status: RESOLVED FIXED

[Adam Bergkvist]

When doing a POST using XMLHttpRequest and sending null or an empty string as body, the method is never set to POST in ResourceHandleManager::setupPOST() (WebCore/platform/network/curl/ResourceHandleManager.cpp).

This will make the POST method test on http://www.mnot.net/javascript/xmlhttprequest/ fail since the method sent is GET.

[Adam Bergkvist]

Created attachment 26523 [details]
Makes sure method is always set to POST in setupPOST().

[Holger Freyther]

The only thing that saddens me is this would have been caugh with the http tests in the LayoutTest directory but we do not run them...

[Holger Freyther]

Comment on attachment 26523 [details]
Makes sure method is always set to POST in setupPOST().


> +    if (!job->request().httpBody())
> +        return;

This does not look correct. An empty PUT will not be finished and the ResourceHandle will be leaked? Could you explain that?

[Adam Bergkvist]

(In reply to comment #3)

I'm not sure I follow.. 
Instead of creating a Vector that is never assigned in case of job->request().httpBody() being null and checking that it has zero elements before returning, I thought it would be better to just return directly.

[Holger Freyther]

Comment on attachment 26523 [details]
Makes sure method is always set to POST in setupPOST().

You are right.

[Holger Freyther]

Landed in r39774.