Bug 231803

Summary: Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, cdumez, changseok, clopez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, pnormand, ryuan.choi, sergio, tomac, tommyw, webkit-bug-importer, will.morgan, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211945, 231945    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2021-10-15 05:25:32 PDT
Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support
Attachments
Patch (88.86 KB, patch)
2021-10-15 05:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (90.95 KB, patch)
2021-10-15 06:46 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (90.76 KB, patch)
2021-10-15 07:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (95.09 KB, patch)
2021-10-18 06:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (96.28 KB, patch)
2021-10-18 07:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (96.70 KB, patch)
2021-10-19 03:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (94.81 KB, patch)
2021-10-20 00:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (94.77 KB, patch)
2021-10-20 04:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-10-15 05:34:53 PDT
Created attachment 441367 [details] Patch
youenn fablet
Comment 2 2021-10-15 06:46:44 PDT
Created attachment 441372 [details] Patch
youenn fablet
Comment 3 2021-10-15 07:15:06 PDT
Created attachment 441376 [details] Patch
Eric Carlson
Comment 4 2021-10-15 09:00:23 PDT
Comment on attachment 441376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441376&action=review > Source/WebCore/html/HTMLVideoElement.cpp:585 > + auto identifier = ++m_nextVideoFrameRequestIndex; Nit: extra space
youenn fablet
Comment 5 2021-10-18 06:01:38 PDT
Created attachment 441594 [details] Patch
youenn fablet
Comment 6 2021-10-18 07:47:07 PDT
Created attachment 441603 [details] Patch
youenn fablet
Comment 7 2021-10-18 23:50:55 PDT
Comment on attachment 441603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441603&action=review > Source/WebCore/html/HTMLVideoElement.cpp:585 > + auto identifier = ++m_nextVideoFrameRequestIndex; Should fix the space, as noticed by Eric.
youenn fablet
Comment 8 2021-10-19 03:46:48 PDT
Created attachment 441707 [details] Patch
Eric Carlson
Comment 9 2021-10-19 08:37:31 PDT
Comment on attachment 441707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441707&action=review > Source/WebCore/html/HTMLVideoElement.cpp:583 > + if (m_nextVideoFrameRequestIndex == std::numeric_limits<unsigned>::max()) > + return 0; This probably log an error, possibly also to the JS console
youenn fablet
Comment 10 2021-10-19 11:33:19 PDT
(In reply to Eric Carlson from comment #9) > Comment on attachment 441707 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441707&action=review > > > Source/WebCore/html/HTMLVideoElement.cpp:583 > > + if (m_nextVideoFrameRequestIndex == std::numeric_limits<unsigned>::max()) > > + return 0; > > This probably log an error, possibly also to the JS console Given we are using a Vector, I guess we should just remove this check.
youenn fablet
Comment 11 2021-10-20 00:26:05 PDT
Created attachment 441855 [details] Patch for landing
EWS
Comment 12 2021-10-20 02:42:34 PDT
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
youenn fablet
Comment 13 2021-10-20 04:06:05 PDT
Created attachment 441864 [details] Patch for landing
EWS
Comment 14 2021-10-20 06:26:30 PDT
Committed r284528 (243270@main): <https://commits.webkit.org/243270@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441864 [details].
Radar WebKit Bug Importer
Comment 15 2021-10-20 06:27:23 PDT
<rdar://problem/84459428>
Note You need to log in before you can comment on or make changes to this bug.