Bug 231803

Summary: Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, cdumez, changseok, clopez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, pnormand, ryuan.choi, sergio, tomac, tommyw, webkit-bug-importer, will.morgan, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211945, 231945    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2021-10-15 05:25:32 PDT 
Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support
Comment 1 youenn fablet 2021-10-15 05:34:53 PDT 
Created attachment 441367 [details]
Patch
Comment 2 youenn fablet 2021-10-15 06:46:44 PDT 
Created attachment 441372 [details]
Patch
Comment 3 youenn fablet 2021-10-15 07:15:06 PDT 
Created attachment 441376 [details]
Patch
Comment 4 Eric Carlson 2021-10-15 09:00:23 PDT 
Comment on attachment 441376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441376&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:585
> +    auto identifier =  ++m_nextVideoFrameRequestIndex;

Nit: extra space
Comment 5 youenn fablet 2021-10-18 06:01:38 PDT 
Created attachment 441594 [details]
Patch
Comment 6 youenn fablet 2021-10-18 07:47:07 PDT 
Created attachment 441603 [details]
Patch
Comment 7 youenn fablet 2021-10-18 23:50:55 PDT 
Comment on attachment 441603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441603&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:585
> +    auto identifier =  ++m_nextVideoFrameRequestIndex;

Should fix the space, as noticed by Eric.
Comment 8 youenn fablet 2021-10-19 03:46:48 PDT 
Created attachment 441707 [details]
Patch
Comment 9 Eric Carlson 2021-10-19 08:37:31 PDT 
Comment on attachment 441707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441707&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:583
> +    if (m_nextVideoFrameRequestIndex == std::numeric_limits<unsigned>::max())
> +        return 0;

This probably log an error, possibly also to the JS console
Comment 10 youenn fablet 2021-10-19 11:33:19 PDT 
(In reply to Eric Carlson from comment #9)
> Comment on attachment 441707 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441707&action=review
> 
> > Source/WebCore/html/HTMLVideoElement.cpp:583
> > +    if (m_nextVideoFrameRequestIndex == std::numeric_limits<unsigned>::max())
> > +        return 0;
> 
> This probably log an error, possibly also to the JS console

Given we are using a Vector, I guess we should just remove this check.
Comment 11 youenn fablet 2021-10-20 00:26:05 PDT 
Created attachment 441855 [details]
Patch for landing
Comment 12 EWS 2021-10-20 02:42:34 PDT 
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Comment 13 youenn fablet 2021-10-20 04:06:05 PDT 
Created attachment 441864 [details]
Patch for landing
Comment 14 EWS 2021-10-20 06:26:30 PDT 
Committed r284528 (243270@main): <https://commits.webkit.org/243270@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441864 [details].
Comment 15 Radar WebKit Bug Importer 2021-10-20 06:27:23 PDT 
<rdar://problem/84459428>