Bug 231798

Summary: Use 0.0.0.0 when "--all-interfaces" is given for websocket_server
Product: WebKit Reporter: Yousuke Kimoto <Yousuke.Kimoto>
Component: Tools / TestsAssignee: Yousuke Kimoto <Yousuke.Kimoto>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Yousuke Kimoto 2021-10-15 01:20:16 PDT
When run-webkit-tests has an option "--all-interfaces", server hosts should use all interfaces on the host PC.
Currently "localhost" is statically used, it is inconvenient in a situation where a host and a target system are discrete because test program on the target system cannot connect to LayoutTest servers on the host PC.
Comment 1 Yousuke Kimoto 2021-10-15 01:37:25 PDT
Created attachment 441347 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-10-22 01:21:34 PDT
<rdar://problem/84540538>
Comment 3 Yousuke Kimoto 2021-10-27 18:05:34 PDT
08:13:10.068 705 Waiting for action: <function <lambda> at 0x108a44f50>
08:13:11.079 705 Server running on 8000
08:13:11.079 705 Server running on 8080
08:13:11.080 705 Server running on 8443
08:13:11.080 705 httpd successfully started (pid = 735)
08:13:11.080 705 Server NOT running on 8880: [Errno 61] Connection refused
08:13:11.080 705 Starting WebSocket server ...
08:13:11.081 705 Using handler_map_file: /Volumes/Data/worker/macOS-Catalina-Release-WK2-Tests-EWS/build/LayoutTests/http/tests/websocket/tests/handler_map.txt

There is the error log on mac-wk2 due to a connection error.
I'm investigating it.
Comment 4 Yousuke Kimoto 2021-11-02 18:38:00 PDT
>08:13:11.080 705 Server NOT running on 8880: [Errno 61] Connection refused

This message can be ignored because other successful tests have the same error in their run-webkit-test logs.
Comment 5 Yousuke Kimoto 2021-11-02 19:11:48 PDT
Created attachment 443161 [details]
Patch

The results from EWS for mac-wk2 seems be weird. To try to apply the new environment on mac-wk2, I added a new patch which doesn't change from the previous one.
Comment 6 Yousuke Kimoto 2021-11-02 20:05:27 PDT
Created attachment 443166 [details]
Patch

Fixed a style check error:

ERROR: Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py:99:  do not use bare 'except'  [pep8/E722] [5]
Comment 7 Yousuke Kimoto 2021-11-02 20:19:18 PDT
Created attachment 443167 [details]
Patch

Updated patch to explain which part is modified.
Comment 8 EWS 2021-11-03 17:40:50 PDT
Committed r285251 (243862@main): <https://commits.webkit.org/243862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443167 [details].