Summary: | Use 0.0.0.0 when "--all-interfaces" is given for websocket_server | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yousuke Kimoto <Yousuke.Kimoto> | ||||||||||
Component: | Tools / Tests | Assignee: | Yousuke Kimoto <Yousuke.Kimoto> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yousuke Kimoto
2021-10-15 01:20:16 PDT
Created attachment 441347 [details]
Patch
08:13:10.068 705 Waiting for action: <function <lambda> at 0x108a44f50> 08:13:11.079 705 Server running on 8000 08:13:11.079 705 Server running on 8080 08:13:11.080 705 Server running on 8443 08:13:11.080 705 httpd successfully started (pid = 735) 08:13:11.080 705 Server NOT running on 8880: [Errno 61] Connection refused 08:13:11.080 705 Starting WebSocket server ... 08:13:11.081 705 Using handler_map_file: /Volumes/Data/worker/macOS-Catalina-Release-WK2-Tests-EWS/build/LayoutTests/http/tests/websocket/tests/handler_map.txt There is the error log on mac-wk2 due to a connection error. I'm investigating it. >08:13:11.080 705 Server NOT running on 8880: [Errno 61] Connection refused
This message can be ignored because other successful tests have the same error in their run-webkit-test logs.
Created attachment 443161 [details]
Patch
The results from EWS for mac-wk2 seems be weird. To try to apply the new environment on mac-wk2, I added a new patch which doesn't change from the previous one.
Created attachment 443166 [details]
Patch
Fixed a style check error:
ERROR: Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py:99: do not use bare 'except' [pep8/E722] [5]
Created attachment 443167 [details]
Patch
Updated patch to explain which part is modified.
Committed r285251 (243862@main): <https://commits.webkit.org/243862@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443167 [details]. |