Bug 231784

Summary:

[Cocoa] Web Inspector: remove _WKInspectorExtensionPrivateForTesting

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, pangle, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1.0	none
Patch v1.0.1 (rebased)	none
Patch v1.1	none
Patch v1.1.1 (rebased)	ews-feeder: commit-queue-

Blaze Burg

Reported 2021-10-14 16:45:21 PDT

Turns out this is needed to implement some parts of Web Extensions.

Attachments
Patch v1.0 (21.85 KB, patch) 2021-10-14 16:56 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Patch v1.0.1 (rebased) (20.45 KB, patch) 2021-10-15 10:53 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Patch v1.1 (21.93 KB, patch) 2021-10-15 11:08 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Patch v1.1.1 (rebased) (23.20 KB, patch) 2021-10-15 16:43 PDT, Blaze Burg	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-10-14 16:45:40 PDT

<rdar://problem/84280608>

Blaze Burg

Comment 2 2021-10-14 16:56:46 PDT

Created attachment 441307 [details] Patch v1.0 This patch must land after a corresponding Safari change to stop using this header/method.

Blaze Burg

Comment 3 2021-10-15 10:53:59 PDT

Created attachment 441401 [details] Patch v1.0.1 (rebased)

Patrick Angle

Comment 4 2021-10-15 11:02:32 PDT

Comment on attachment 441401 [details] Patch v1.0.1 (rebased) View in context: https://bugs.webkit.org/attachment.cgi?id=441401&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85 > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler; Can this be above `reloadIgnoringCache` so it is next to the other `evaluateScript`? > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126 > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler Ditto _WKInspectorExtension.h:85

Blaze Burg

Comment 5 2021-10-15 11:04:44 PDT

(In reply to Patrick Angle from comment #4) > Comment on attachment 441401 [details] > Patch v1.0.1 (rebased) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441401&action=review > > > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85 > > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler; > > Can this be above `reloadIgnoringCache` so it is next to the other > `evaluateScript`? > > > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126 > > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler > > Ditto _WKInspectorExtension.h:85 Sure!

Blaze Burg

Comment 6 2021-10-15 11:08:25 PDT

Created attachment 441405 [details] Patch v1.1

Blaze Burg

Comment 7 2021-10-15 16:39:32 PDT

(In reply to BJ Burg from comment #6) > Created attachment 441405 [details] > Patch v1.1 Looks like I forgot one.

Blaze Burg

Comment 8 2021-10-15 16:43:47 PDT

Created attachment 441455 [details] Patch v1.1.1 (rebased)

EWS

Comment 9 2021-10-15 20:33:39 PDT

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Blaze Burg

Comment 10 2021-10-17 12:00:51 PDT

Committed r284337 (243132@main): <https://commits.webkit.org/243132@main>

Note You need to log in before you can comment on or make changes to this bug.