Bug 231716 – Compilation error: In file included from ./b3/B3StackmapGenerationParams.h:31: ./b3/B3ValueRep.h:119:5: error: definition of implicit copy assignment operator for 'ValueRep' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecat

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

When compiling I get:

In file included from ./b3/B3StackmapGenerationParams.h:31:
./b3/B3ValueRep.h:119:5: error: definition of implicit copy assignment operator for 'ValueRep' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
    ValueRep(const ValueRep&) = default;
/b3/B3StackmapValue.cpp:77:19: note: in implicit copy assignment operator for 'JSC::B3::ValueRep' first required here
    m_reps[index] = rep;

Per C++11 and later:
“The generation of the implicitly-defined copy assignment operator is deprecated if T has a user-declared destructor or user-declared copy constructor. (since C++11)”

so it's missing a copy assignment operator definition.

[Radar WebKit Bug Importer]

<rdar://problem/84230556>

[Jean-Yves Avenard [:jya]]

Created attachment 441180 [details]
Patch

[Yusuke Suzuki]

Ah, I already landed unreviewed build fix https://github.com/WebKit/WebKit/commit/9068b467eb20d0e553678c13b8eeed8c8d5b7d93 :)

[Jean-Yves Avenard [:jya]]

(In reply to Yusuke Suzuki from comment #3)
> Ah, I already landed unreviewed build fix
> https://github.com/WebKit/WebKit/commit/
> 9068b467eb20d0e553678c13b8eeed8c8d5b7d93 :)

that will fix it too.

that copy constructor wasn't used. I hesitated between the two fixes

[Jean-Yves Avenard [:jya]]

been fixed already