Bug 231682 – REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails

• Component: WebGL
• Status: RESOLVED FIXED

[Jon Lee]

WebGL bot shows webgl/2.0.0/deqp/functional/gles3/lifetime.html fails after r283667.

[Radar WebKit Bug Importer]

<rdar://problem/84204653>

[Kenneth Russell]

Kyle, could you investigate this regression? If shaders are failing to compile then arbitrary WebGL applications might be impacted.

[Kyle Piddington]

Created attachment 441126 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kimmo Kinnunen]

Comment on attachment 441126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441126&action=review

some whitespace issues..

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:261
> +                << "ANGLE_vertexOut.";

whitespace: maybe match the indent or align the whole statement.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:262
> +                if(!varying.isBuiltIn())

nit: space after if

[Kyle Piddington]

Created attachment 441442 [details]
Patch for landing

[EWS]

Committed r284293 (243091@main): <https://commits.webkit.org/243091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441442 [details].