Bug 231672

Summary: CLang build warning in CheckedPtr.h
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Web Template FrameworkAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Philippe Normand
Reported 2021-10-13 06:15:39 PDT
/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h:108:52: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] inline const T& operator*() const { do { if (!(this)) { WTFReportAssertionFailure("/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", 108, __PRETTY_FUNCTION__, "this"); do { WTF::isIntegralOrPointerType(); compilerFenceForCrash(); WTFCrashWithInfo(108, "/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", __PRETTY_FUNCTION__, 2989); } while (false); } } while (0); return *get(); } ~ ^~~~ /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h:74:51: note: in instantiation of member function 'WTF::CheckedPtr<const WebCore::LayoutIntegration::LineLayout>::operator*' requested here const LineLayout& lineLayout() const { return *m_lineLayout; } ^ 2 warnings generated.
Attachments
Patch (1.59 KB, patch)
2021-10-13 06:21 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2021-10-13 06:39 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2021-10-13 06:39 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-10-13 06:21:52 PDT
Created attachment 441065 [details] Patch
Philippe Normand
Comment 2 2021-10-13 06:39:31 PDT
Created attachment 441068 [details] Patch
Philippe Normand
Comment 3 2021-10-13 06:39:58 PDT
Created attachment 441069 [details] Patch
EWS
Comment 4 2021-10-13 07:33:13 PDT
Committed r284092 (242920@main): <https://commits.webkit.org/242920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441069 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-13 07:34:17 PDT
<rdar://problem/84197572>
Note You need to log in before you can comment on or make changes to this bug.