| Summary: | CLang build warning in CheckedPtr.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||
| Component: | Web Template Framework | Assignee: | Philippe Normand <pnormand> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 441065 [details]
Patch
Created attachment 441068 [details]
Patch
Created attachment 441069 [details]
Patch
Committed r284092 (242920@main): <https://commits.webkit.org/242920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441069 [details]. |
/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h:108:52: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] inline const T& operator*() const { do { if (!(this)) { WTFReportAssertionFailure("/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", 108, __PRETTY_FUNCTION__, "this"); do { WTF::isIntegralOrPointerType(); compilerFenceForCrash(); WTFCrashWithInfo(108, "/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", __PRETTY_FUNCTION__, 2989); } while (false); } } while (0); return *get(); } ~ ^~~~ /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h:74:51: note: in instantiation of member function 'WTF::CheckedPtr<const WebCore::LayoutIntegration::LineLayout>::operator*' requested here const LineLayout& lineLayout() const { return *m_lineLayout; } ^ 2 warnings generated.