Bug 231666

Summary:

Add my github username to contributors.json

Product:

WebKit

Reporter:

Sergey Rubanov <chi187>

Component:

New Bugs

Assignee:

Sergey Rubanov <chi187>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch	none

Description Sergey Rubanov 2021-10-13 03:20:25 PDT

Add my github username to contributors.json

Comment 1 Sergey Rubanov 2021-10-13 03:26:40 PDT

Created attachment 441052 [details]
Patch

Comment 2 Sergey Rubanov 2021-10-13 03:32:44 PDT

I've also run validation script in the patch, so it includes some more corrections in contributors.json

Comment 3 Alexey Proskuryakov 2021-10-13 16:58:57 PDT

Did you intend to mark this patch for r?/cq?

Comment 4 Sergey Rubanov 2021-10-14 02:14:17 PDT

(In reply to Alexey Proskuryakov from comment #3)
> Did you intend to mark this patch for r?/cq?

I've marked it as r?/cq?

Comment 5 Radar WebKit Bug Importer 2021-10-20 03:21:16 PDT

<rdar://problem/84455042>

Comment 6 Alexey Proskuryakov 2021-10-29 10:06:38 PDT

Apologies, forgot to CC myself to track.

Comment 7 EWS 2021-10-29 10:07:11 PDT

Tools/Scripts/svn-apply failed to apply attachment 441052 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 8 Sergey Rubanov 2021-12-25 00:15:34 PST

Comment on attachment 441052 [details]
Patch

>Subversion Revision: 284084
>diff --git a/ChangeLog b/ChangeLog
>index 78b4b988b48e1e8c473cd0d4e6f725ec4b2a9f98..e5dd8f1f029199abb0dbf1d98840d2f966b8b7bf 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2021-10-13  Sergey Rubanov  <chi187@gmail.com>
>+
>+        Add my github username to contributors.json
>+        https://bugs.webkit.org/show_bug.cgi?id=231666
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * metadata/contributors.json:
>+
> 2021-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Add my github username to contributors.json
>diff --git a/metadata/contributors.json b/metadata/contributors.json
>index a5ba33b85e7a071a0fd25fff931f0b9df1992591..66c93014e6d1cb77590b33be5dfffa12db852ce1 100644
>--- a/metadata/contributors.json
>+++ b/metadata/contributors.json
>@@ -5797,6 +5797,8 @@
>       "emails" : [
>          "chi187@gmail.com"
>       ],
>+      "expertise" : "WebAssembly",
>+      "github" : "chicoxyzzy",
>       "name" : "Sergey Rubanov",
>       "nicks" : [
>          "chicoxyzzy"
>\ No newline at end of file

Comment 9 Sergey Rubanov 2021-12-25 00:22:54 PST

Created attachment 447956 [details]
[fast-cq] Patch

Comment 10 EWS 2021-12-25 11:19:49 PST

Committed r287439 (245574@main): <https://commits.webkit.org/245574@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447956 [details].