Bug 231651

Summary: Stop using makeWeakPtr() in WebCore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, calvaris, cgarcia, changseok, cmarcelo, darin, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, ggaren, glenn, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jer.noble, jfernandez, joepeck, kangil.han, kondapallykalyan, luiz, menard, mifenton, pangle, pdr, philipj, pnormand, rego, sabouhallawa, sam, schenney, sergio, simon.fraser, svillar, tommyw, tonikitoo, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231580    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-10-12 17:50:43 PDT
Stop using makeWeakPtr() in WebCore and use WeakPtr { } directly instead.
Attachments
Patch (220.50 KB, patch)
2021-10-12 18:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (220.32 KB, patch)
2021-10-12 19:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (219.85 KB, patch)
2021-10-13 07:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-10-12 18:08:21 PDT
Created attachment 441025 [details] Patch
Chris Dumez
Comment 2 2021-10-12 19:22:50 PDT
Created attachment 441032 [details] Patch
Alex Christensen
Comment 3 2021-10-13 07:24:18 PDT
Comment on attachment 441032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441032&action=review > Source/WebCore/html/HTMLMediaElement.h:1171 > + WeakPtr<MediaResourceLoader> m_lastMediaResourceLoaderForTesting; no more const?
Chris Dumez
Comment 4 2021-10-13 07:30:10 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 441032 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441032&action=review > > > Source/WebCore/html/HTMLMediaElement.h:1171 > > + WeakPtr<MediaResourceLoader> m_lastMediaResourceLoaderForTesting; > > no more const? I'll check if I can keep it.
Chris Dumez
Comment 5 2021-10-13 07:47:14 PDT
Created attachment 441078 [details] Patch
Chris Dumez
Comment 6 2021-10-13 08:38:03 PDT
Comment on attachment 441078 [details] Patch Clearing flags on attachment: 441078 Committed r284093 (242921@main): <https://commits.webkit.org/242921@main>
Chris Dumez
Comment 7 2021-10-13 08:38:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2021-10-13 08:39:18 PDT
<rdar://problem/84199640>
Note You need to log in before you can comment on or make changes to this bug.