Bug 231647

Summary: REGRESSION (r283935): [ macOS wk1 ] imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html is a flaky failure
Product: WebKit Reporter: ayumi_kojima
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, koivisto, ntim, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/31365
Bug Depends on:    
Bug Blocks: 203139    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch koivisto: review+

Description ayumi_kojima 2021-10-12 16:41:33 PDT
imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html 

Is a flaky failure on macOS wk1.

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fselectors%2Ffocus-visible-009.html

Result page: https://build.webkit.org/results/Apple-BigSur-Release-AppleSilicon-WK1-Tests/r283939%20(5363)/results.html

Diff:

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-actual.txt
@@ -3,5 +3,7 @@
 
 I will be focused automatically.
 
-PASS Autofocus should match :focus-visible
+Harness Error (TIMEOUT), message = null
 
+TIMEOUT Autofocus should match :focus-visible Test timed out
+

The test is also showing up on EWS as a flaky test.
Comment 1 Radar WebKit Bug Importer 2021-10-12 16:42:29 PDT
<rdar://problem/84172460>
Comment 2 ayumi_kojima 2021-10-12 16:47:06 PDT
Marked test expectations https://trac.webkit.org/changeset/284061/webkit
Comment 3 Alexey Proskuryakov 2021-10-13 17:10:58 PDT
First instance in r283937, I bet that r283935 is the culprit.
Comment 4 Tim Nguyen (:ntim) 2021-10-25 01:21:45 PDT
Created attachment 442343 [details]
Patch
Comment 5 EWS Watchlist 2021-10-25 01:23:06 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 6 Tim Nguyen (:ntim) 2021-10-25 01:32:13 PDT
Created attachment 442344 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2021-10-25 01:34:33 PDT
Created attachment 442345 [details]
Patch
Comment 8 Tim Nguyen (:ntim) 2021-10-25 01:36:42 PDT
Created attachment 442346 [details]
Patch
Comment 9 Tim Nguyen (:ntim) 2021-10-25 01:39:37 PDT
Created attachment 442348 [details]
Patch
Comment 10 Tim Nguyen (:ntim) 2021-10-25 01:40:39 PDT
Created attachment 442349 [details]
Patch
Comment 11 Tim Nguyen (:ntim) 2021-10-25 01:41:07 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/31365
Comment 12 Tim Nguyen (:ntim) 2021-10-25 01:58:51 PDT
Committed r284774 (243483@main): <https://commits.webkit.org/243483@main>