Summary: | suppress scrolling in Element::updateFocusAppearance | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cary Clark <caryclark> | ||||
Component: | DOM | Assignee: | Cary Clark <caryclark> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, eric, tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Bug Depends on: | 23145 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Cary Clark
2009-01-07 07:33:26 PST
Created attachment 26491 [details]
don't scroll when setting focus for devices with directional pad navigation
Comment on attachment 26491 [details]
don't scroll when setting focus for devices with directional pad navigation
It seems to me that the real issue here isn't exactly "directional pad navigation" -- it's more "small screen with explicit scrolling", and I suppose the explicit scrolling part is what's really relevant. I could easily imagine someone using WebKit on a web browser for a TV screen, and using a directional pad on a remote control. It's entirely unclear to me whether the presence of the directional pad would also cause the developers to want this behavior in that case.
I'm going to say r=me with this, but I think we're being a bit unclear on what DIRECTIONAL_PAD_NAVIGATION means and that could become a problem down the line.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Element.cpp Committed r40647 Patch was wrong, fixed: Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Element.cpp Committed r40654 it is interesing that this patch landed, and its BLOCKER did not. It introduced: ======================================= #if !ENABLE(DIRECTIONAL_PAD_NAVIGATION) else if (renderer() && !renderer()->isWidget()) renderer()->enclosingLayer()->scrollRectToVisible(getRect()); #endif ======================================= but DIRECTIONAL_PAD_NAVIGATION is not even in Platform.h . Grep'ing for it outputs only: $ grep -nHR DIRECTIONAL_PAD_NAVIGATION . ./WebCore/dom/Element.cpp:1293:#if !ENABLE(DIRECTIONAL_PAD_NAVIGATION) cc'ing darin who reviwed and eric who landed it. This is something that was put in for Android. Beyond that I have little insight into what it is or if it should be removed or kept. |