Bug 231601

Summary:

[ iOS Release ] fast/mediastream/mediaElement-gc.html is a flaky failure

Product:

WebKit

Reporter:

ayumi_kojima

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description ayumi_kojima 2021-10-12 11:44:39 PDT

fast/mediastream/mediaElement-gc.html

Is a flaky failure on iOS 15 Release.

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2FmediaElement-gc.html

Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r283979%20(142)/results.html#

Diff:

--- /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/fast/mediastream/mediaElement-gc-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/fast/mediastream/mediaElement-gc-actual.txt
@@ -1,4 +1,4 @@
 
 PASS Keep alive a video element with a live srcObject
-PASS GC a video element with a live srcObject, then srcObject set to null
+FAIL GC a video element with a live srcObject, then srcObject set to null assert_true: expected true got false

Comment 1 Radar WebKit Bug Importer 2021-10-12 11:46:13 PDT

<rdar://problem/84158942>

Comment 2 ayumi_kojima 2021-10-12 11:48:23 PDT

Marked test expectations https://trac.webkit.org/changeset/283996/webkit

Comment 3 ayumi_kojima 2021-10-15 15:02:48 PDT

I was not able to reproduce the failure locally on iOS 15 simulator using run-webkit-tests --force --ios-simulator --iterations 500 --exit-after-n-failures 1 fast/mediastream/mediaElement-gc.html

Comment 4 ayumi_kojima 2021-10-15 15:06:59 PDT

It looks like the same diff as this Bug 226991.

Comment 5 youenn fablet 2022-01-24 04:43:45 PST

Looking at the last failure:
- PASS Keep alive a video element with a live srcObject
- PASS GC a video element with a live srcObject, then srcObject set to null
+ FAIL Keep alive a video element with a live srcObject assert_equals: expected 1 but got 2
+ FAIL GC a video element with a live srcObject, then srcObject set to null assert_true: expected true got false

It seems there might be remaining media elements from the previous test.
We can update mediaElementCount to only count elements of a given document.

Comment 6 youenn fablet 2022-01-24 05:01:07 PST

Created attachment 449803 [details]
Patch

Comment 7 EWS 2022-01-24 13:12:10 PST

Committed r288462 (246348@main): <https://commits.webkit.org/246348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449803 [details].