Summary: | REGRESSION: (r283871) [ macOS wk2 Release ] 2 css/cssom-view/scroll-behavior-main-frame tests are failing | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Hutchison <ehutchison> | ||||||||||||
Component: | CSS | Assignee: | Nikos Mouchtaris <nmouchtaris> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, changseok, cmarcelo, ehutchison, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, kangil.han, koivisto, kondapallykalyan, luiz, mifenton, nmouchtaris, pdr, simon.fraser, tonikitoo, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Eric Hutchison
2021-10-12 11:40:24 PDT
Updated test expectations at https://trac.webkit.org/changeset/284000/webkit Created attachment 443854 [details]
Patch
Created attachment 443883 [details]
Patch
Created attachment 443886 [details]
Patch
Comment on attachment 443886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443886&action=review I think the real bug might be that ThreadedScrollingTree::scrollingTreeNodeRequestsScroll() should use m_nodesWithPendingScrollAnimations.set() instead of m_nodesWithPendingScrollAnimations.add() (see HashMap.h) > Source/WebCore/ChangeLog:9 > + Temporary fix for issue where second scroll doesn't cancel a current > + scroll animation. Is it temporary? Comment on attachment 443886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443886&action=review > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:256 > + scrollingTree().clearAnimationsForScrollingNodeID(scrollingNodeID()); > > if (requestedScrollData.requestType == ScrollRequestType::CancelAnimatedScroll) > return; But maybe we do need to clear the pending animation if we hit the CancelAnimatedScroll clause. Created attachment 443911 [details]
Patch
Comment on attachment 443911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443911&action=review > Source/WebCore/ChangeLog:10 > + request has come in (first animation still in m_nodesWithPendingScrollAnimations). For the "come in" could be more specific. Maybe "committed to the scrolling tree" or "received by the scrolling thread", whichever it is. > Source/WebCore/page/scrolling/ThreadedScrollingTree.h:67 > + void removePendingScrollAnimationForNode(ScrollingNodeID nodeID) WTF_REQUIRES_LOCK(m_treeLock) override { m_nodesWithPendingScrollAnimations.remove(nodeID); } Since this is virtual, I would move the implementation to the .cpp file. I think it can be 'final' instead of 'override'. Created attachment 443990 [details]
Patch
Committed r285669 (244156@main): <https://commits.webkit.org/244156@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443990 [details]. |