| Summary: | Scrolling thread animations need to commit layers on the scrolling thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 188043 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2021-10-12 10:23:53 PDT
Created attachment 440955 [details]
Patch
Comment on attachment 440955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440955&action=review > Source/WebKit/ChangeLog:8 > + Scroll animations were running the scrolling thread (in that the timers were firing on that "on" > Source/WebKit/ChangeLog:9 > + thread), but the scrolling thread wasn't changing layer positons, so those animations positons! > Source/WebKit/ChangeLog:26 > + Scroll animations are still based on a 60Hz timer, but in future should be driven by > + displayDidRefresh() notifications. Excitement! Created attachment 440967 [details]
Patch
Created attachment 440973 [details]
Patch
Reverted r284022 for reason: Caused tests to exit early due to an assertion failure Committed r284049 (242878@main): <https://commits.webkit.org/242878@main> (In reply to Ryan Haddad from comment #7) > Reverted r284022 for reason: > > Caused tests to exit early due to an assertion failure ASSERTION FAILED: connectionInfo.fullSpeedUpdatesClientCount /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/Source/WebKit/UIProcess/mac/DisplayLink.cpp(186) : void WebKit::DisplayLink::decrementFullSpeedRequestClientCount(IPC::Connection &) https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r440955-14272-rerun/results.html Re-landed in https://trac.webkit.org/changeset/284064/webkit |