Bug 231591

Summary: [Python-3] Invoke webkit-patch with Python 3 by default
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dewei_zhu, ews-watchlist, glenn, mcatanzaro, ryanhaddad, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237396    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2021-10-12 10:22:09 PDT
webkit-patch workflows should support Python 3 now, so we should change the shebang.
Attachments
Patch (1.11 KB, patch)
2021-10-12 10:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.16 KB, patch)
2022-03-01 10:23 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2022-03-03 07:54 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-12 10:22:46 PDT
<rdar://problem/84153640>
Jonathan Bedard
Comment 2 2021-10-12 10:24:01 PDT
Created attachment 440952 [details] Patch
EWS
Comment 3 2021-10-12 12:39:11 PDT
Committed r284005 (242848@main): <https://commits.webkit.org/242848@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440952 [details].
Jonathan Bedard
Comment 4 2021-10-18 17:35:31 PDT
Committed r284417 (243185@main): <https://commits.webkit.org/243185@main>
Jonathan Bedard
Comment 5 2022-03-01 10:23:13 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 6 2022-03-01 10:23:15 PST
Created attachment 453510 [details] Patch
Jonathan Bedard
Comment 7 2022-03-01 10:24:53 PST
The reason this got reverted previously is that WebKitBot had trouble. I did some investigation today, and that appears to be because WebKitBot has trouble with auto installing in general. That problem can be worked around by priming the autoinstalled cache, though. So we should re-landing this change.
EWS
Comment 8 2022-03-02 13:13:48 PST
Committed r290753 (247997@main): <https://commits.webkit.org/247997@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453510 [details].
WebKit Commit Bot
Comment 9 2022-03-02 16:09:36 PST
Re-opened since this is blocked by bug 237396
Jonathan Bedard
Comment 10 2022-03-02 16:11:03 PST
Tried a revert with the Slackbot to make sure everything was working, and it would appear to be: https://bugs.webkit.org/show_bug.cgi?id=237396
Jonathan Bedard
Comment 11 2022-03-03 07:54:05 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 12 2022-03-03 07:54:07 PST
Created attachment 453737 [details] Patch
EWS
Comment 13 2022-03-03 08:55:10 PST
Committed r290777 (248021@main): <https://commits.webkit.org/248021@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453737 [details].
Note You need to log in before you can comment on or make changes to this bug.