Summary: | Invoke build scripts with python3 explicitly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, hysu, jbedard, joepeck, keith_miller, macpherson, mark.lam, mcatanzaro, menard, msaboff, pangle, ryanhaddad, saam, tzagallo | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=156674 https://bugs.webkit.org/show_bug.cgi?id=231605 |
||||||
Attachments: |
|
Description
Alexey Proskuryakov
2021-10-12 10:00:09 PDT
Created attachment 440958 [details]
proposed patch
(In reply to Alexey Proskuryakov from comment #1) > Created attachment 440958 [details] > proposed patch Looks reasonable, let's let EWS double-check we're not going to break any builds This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Comment on attachment 440958 [details]
proposed patch
This is good for Linux too. Currently some distros have /usr/bin/python -> /usr/bin/python2 and others have /usr/bin/python -> /usr/bin/python3 and others just decided to delete /usr/bin/python altogether to avoid the confusion. Explicit is better than implicit....
This doesn't touch ThirdParty yet, that will be a separate patch. Comment on attachment 440958 [details]
proposed patch
Windows build succeeded on retry, so must have been either an unrelated glitch, or a misconfigured bot. cq+
Comment on attachment 440958 [details]
proposed patch
Actually no, I need to land this manually.
*** Bug 226615 has been marked as a duplicate of this bug. *** *** Bug 226631 has been marked as a duplicate of this bug. *** *** Bug 226617 has been marked as a duplicate of this bug. *** |