Bug 231570

Summary: [iOS] Stop including 'util.sb' in the WebContent process' sandbox
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: REOPENED    
Severity: Normal CC: bfulgham, commit-queue, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231984    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2021-10-12 05:47:59 PDT
This is a step towards being able to test-compile the sandbox on Open Source builders.
Attachments
Patch (5.78 KB, patch)
2021-10-12 05:51 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-12 05:49:42 PDT
<rdar://problem/84143956>
Per Arne Vollan
Comment 2 2021-10-12 05:51:12 PDT
Created attachment 440922 [details] Patch
Brent Fulgham
Comment 3 2021-10-12 10:32:32 PDT
Comment on attachment 440922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440922&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:-38 > -(import "util.sb") Can any of the other sandboxes use our slimmed-down util.sb?
Per Arne Vollan
Comment 4 2021-10-13 09:32:50 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 440922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440922&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:-38 > > -(import "util.sb") > > Can any of the other sandboxes use our slimmed-down util.sb? That is a good point! We're only preprocessing the WP sandbox on iOS. When the other sandboxes are preprocessed as well, we should use the new util.sb there too. Thanks for reviewing!
EWS
Comment 5 2021-10-13 10:00:48 PDT
Committed r284099 (242927@main): <https://commits.webkit.org/242927@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440922 [details].
WebKit Commit Bot
Comment 6 2021-10-19 14:35:48 PDT
Re-opened since this is blocked by bug 231984
Note You need to log in before you can comment on or make changes to this bug.