Bug 231561

Summary: [LFC][Integration] Add support for painting inline box decorations
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231556, 231562    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2021-10-12 00:08:28 PDT 
Borders, backgrounds etc
Comment 1 Antti Koivisto 2021-10-12 00:23:42 PDT 
Created attachment 440902 [details]
Patch
Comment 2 Antti Koivisto 2021-10-12 02:50:42 PDT 
Created attachment 440914 [details]
Patch
Comment 3 zalan 2021-10-12 06:19:05 PDT 
Comment on attachment 440914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440914&action=review

> Source/WebCore/ChangeLog:27
> +        (WebCore::LayoutIntegration::LineLayout::paintTextBoxUsingPhysicalCoordinates): Deleted.

InlineBoxPainter does the coordinate flipping now?
Comment 4 Antti Koivisto 2021-10-12 07:07:51 PDT 
> InlineBoxPainter does the coordinate flipping now?

Always did.
Comment 5 Antti Koivisto 2021-10-12 07:09:19 PDT 
Created attachment 440925 [details]
Patch
Comment 6 EWS 2021-10-12 08:44:05 PDT 
Committed r283981 (242827@main): <https://commits.webkit.org/242827@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440925 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-12 08:45:55 PDT 
<rdar://problem/84148970>