Bug 231560

Summary: Implement alternate style for textarea
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, changseok, esprehn+autocc, ews-watchlist, glenn, hi, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2021-10-11 23:35:37 PDT
Implement alternate style for textarea
Attachments
Patch (3.25 KB, patch)
2021-10-11 23:38 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2021-10-12 15:19 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-10-11 23:38:44 PDT
Created attachment 440899 [details] Patch
Devin Rousso
Comment 2 2021-10-12 11:18:31 PDT
Comment on attachment 440899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440899&action=review r=me > Source/WebCore/rendering/RenderThemeIOS.mm:607 > + if (is<HTMLTextAreaElement>(*element)) NIT: Should this be an `else if` so we don't check it if we enter the `if (is<HTMLInputElement>(*element))` above? > Source/WebCore/rendering/RenderThemeIOS.mm:641 > + bool useAlternateDesign = element->document().settings().alternateFormControlDesignEnabled(); NIT: Does this need to be a separate variable?
Tim Horton
Comment 3 2021-10-12 11:23:11 PDT
Both fair!
Tim Horton
Comment 4 2021-10-12 15:19:50 PDT
Created attachment 441000 [details] Patch
Radar WebKit Bug Importer
Comment 5 2021-10-12 15:35:58 PDT
<rdar://problem/84169599>
EWS
Comment 6 2021-10-12 18:00:04 PDT
Committed r284070 (242898@main): <https://commits.webkit.org/242898@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441000 [details].
Note You need to log in before you can comment on or make changes to this bug.