Bug 231533

Summary: Fix makeprop.pl to not treat "inherited: false" properties as inherited.
Product: WebKit Reporter: Kiet Ho <kiet.ho>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kiet.ho, macpherson, menard, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Kiet Ho 2021-10-11 14:03:24 PDT 
makeprop.pl treats a property as inherited if the "inherited" option in CSSProperties.json is defined, regardless of whether the option value is true or false. Fix makeprop.pl to actually consider the option value.
Comment 1 Kiet Ho 2021-10-11 14:23:13 PDT 
Created attachment 440834 [details]
Patch
Comment 2 EWS 2021-10-11 19:48:39 PDT 
Committed r283963 (242810@main): <https://commits.webkit.org/242810@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440834 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-11 19:49:18 PDT 
<rdar://problem/84128720>
Comment 4 Darin Adler 2021-10-12 08:38:43 PDT 
Why no tests? Doesn’t this affect anything?