Bug 231485

Summary: [LFC][IFC] Do no bail out on boundary neutral characters
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-10-09 19:49:20 PDT
ssia
Attachments
Patch (4.23 KB, patch)
2021-10-09 19:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.00 KB, patch)
2021-10-10 06:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-10-09 19:52:03 PDT
Created attachment 440723 [details] Patch
alan
Comment 2 2021-10-09 21:23:37 PDT
They look progressions. will rebaseline.
Antti Koivisto
Comment 3 2021-10-09 22:13:05 PDT
Comment on attachment 440723 [details] Patch The failure in fast/text/text-underline-first-line-decoration.html can be handled by altering the test or exceptions.
alan
Comment 4 2021-10-10 06:37:16 PDT
Created attachment 440727 [details] Patch
Antti Koivisto
Comment 5 2021-10-10 07:16:35 PDT
Comment on attachment 440727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440727&action=review > LayoutTests/fast/text/text-underline-first-line-decoration-expected.html:11 > +<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration, but not </span></span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline; vertical-align:-20px"> under the image.&ZeroWidthSpace;</span></span><br> Probably don't need that ZeroWidthSpace there, it was just an earlier attempt to fix the test.
EWS
Comment 6 2021-10-10 09:05:53 PDT
Committed r283875 (242752@main): <https://commits.webkit.org/242752@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440727 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-10 09:06:20 PDT
<rdar://problem/84076520>
alan
Comment 8 2021-10-10 13:48:16 PDT
(In reply to Antti Koivisto from comment #5) > Comment on attachment 440727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440727&action=review > > > LayoutTests/fast/text/text-underline-first-line-decoration-expected.html:11 > > +<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration, but not </span></span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline; vertical-align:-20px"> under the image.&ZeroWidthSpace;</span></span><br> > > Probably don't need that ZeroWidthSpace there, it was just an earlier > attempt to fix the test. :(
Note You need to log in before you can comment on or make changes to this bug.