Bug 231411

Summary: [GPU Process] Unique RenderingResourceIdentifiers Part 8: Consolidate DisplayList::ResourceHeap
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217638    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
simon.fraser: review+, ews-feeder: commit-queue-
Patch for committing
none
Patch for committing none

Myles C. Maxfield
Reported 2021-10-07 21:51:13 PDT
Consolidate DisplayList::ResourceHeap
Attachments
Patch (37.43 KB, patch)
2021-10-07 22:31 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (38.03 KB, patch)
2021-10-07 22:34 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (37.83 KB, patch)
2021-10-07 23:33 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (37.79 KB, patch)
2021-10-08 10:27 PDT, Myles C. Maxfield 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (40.60 KB, patch)
2021-10-11 22:39 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (40.60 KB, patch)
2021-10-11 23:34 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-07 21:51:56 PDT
<rdar://problem/84013167>
Myles C. Maxfield
Comment 2 2021-10-07 22:31:27 PDT
Created attachment 440573 [details] Patch
Myles C. Maxfield
Comment 3 2021-10-07 22:34:34 PDT
Created attachment 440574 [details] Patch
Myles C. Maxfield
Comment 4 2021-10-07 22:43:27 PDT
Comment on attachment 440574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440574&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:44 > + using ImageBufferHashMap = HashMap<RenderingResourceIdentifier, Ref<ImageBuffer>>; > + using NativeImageHashMap = HashMap<RenderingResourceIdentifier, Ref<NativeImage>>; > + using FontRenderingResourceMap = HashMap<RenderingResourceIdentifier, Ref<Font>>; > + > + ResourceHeap() = default; These are unnecessary.
Myles C. Maxfield
Comment 5 2021-10-07 23:33:04 PDT
Created attachment 440575 [details] Patch
Myles C. Maxfield
Comment 6 2021-10-08 10:27:43 PDT
Created attachment 440639 [details] Patch
Simon Fraser (smfr)
Comment 7 2021-10-11 21:39:22 PDT
Comment on attachment 440639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440639&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:115 > + HashMap<RenderingResourceIdentifier, Ref<ImageBuffer>> m_imageBuffers; > + HashMap<RenderingResourceIdentifier, Ref<NativeImage>> m_nativeImages; > + HashMap<RenderingResourceIdentifier, Ref<Font>> m_fonts; Did you consider HashMap<RenderingResourceIdentifier, Variant<....>> ? An identifier will never be shared between these types, right?
Myles C. Maxfield
Comment 8 2021-10-11 22:09:15 PDT Comment hidden (obsolete)
Myles C. Maxfield
Comment 9 2021-10-11 22:31:40 PDT Comment hidden (obsolete)
Myles C. Maxfield
Comment 10 2021-10-11 22:39:48 PDT
Created attachment 440892 [details] Patch for committing
Myles C. Maxfield
Comment 11 2021-10-11 23:34:55 PDT
Created attachment 440897 [details] Patch for committing
Myles C. Maxfield
Comment 12 2021-10-12 01:05:26 PDT
Committed r283971 (242818@main): <https://commits.webkit.org/242818@main>
Note You need to log in before you can comment on or make changes to this bug.