| Summary: | CSSProperties.json should not require a 'converter' for color properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||
| Component: | Tools / Tests | Assignee: | Aditya Keerthi <akeerthi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aditya Keerthi
2021-10-07 10:57:49 PDT
Renamed from "makeprop.pl should support 'auto-functions' for color properties", since it technically already does. The only issue was an incorrect value setter, which can be fixed by specifying a 'converter'. However, I feel 'converter' is redundant for 'color-property', given that we already know we need to cover to a Color. (In reply to Aditya Keerthi from comment #1) > Renamed from "makeprop.pl should support 'auto-functions' for color > properties", since it technically already does. The only issue was an > incorrect value setter, which can be fixed by specifying a 'converter'. > > However, I feel 'converter' is redundant for 'color-property', given that we > already know we need to cover to a Color. s/cover/convert/ Created attachment 440565 [details]
Patch
Comment on attachment 440565 [details]
Patch
nice!
Committed r284207 (243018@main): <https://commits.webkit.org/243018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440565 [details]. |