Bug 231344 – [iOS] Get rid of the deviceClass function, up-leveling to deviceClassIsSmallScreen

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Darin Adler]

Get rid of the deviceClass function, up-leveling to deviceClassIsSmallScreen

[Darin Adler]

Created attachment 440459 [details]
Patch

[Darin Adler]

Tim, did what I said and what you said.

[Tim Horton]

Comment on attachment 440459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440459&action=review

Love it! I'm still trying to puzzle out `deviceHasIPadCapability` with folks.

> Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:72
>  #if PLATFORM(MACCATALYST)
>      return true;
>  #elif PLATFORM(IOS)

Probably (?) could get rid of this ifdef

> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:278
>  #if PLATFORM(MACCATALYST)
>      return true;

And again

[Darin Adler]

Comment on attachment 440459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440459&action=review

>> Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:72
>>  #elif PLATFORM(IOS)
> 
> Probably (?) could get rid of this ifdef

Good point. If we want to do compile time optimization we can do that in Device.h/cpp instead of here. Will do.

[Darin Adler]

Committed r283721 (242645@main): <https://commits.webkit.org/242645@main>

[Radar WebKit Bug Importer]

<rdar://problem/83989632>