| Summary: | [iOS] Get rid of the deviceClass function, up-leveling to deviceClassIsSmallScreen | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2021-10-06 17:23:21 PDT
Created attachment 440459 [details]
Patch
Tim, did what I said and what you said. Comment on attachment 440459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440459&action=review Love it! I'm still trying to puzzle out `deviceHasIPadCapability` with folks. > Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:72 > #if PLATFORM(MACCATALYST) > return true; > #elif PLATFORM(IOS) Probably (?) could get rid of this ifdef > Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:278 > #if PLATFORM(MACCATALYST) > return true; And again Comment on attachment 440459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440459&action=review >> Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:72 >> #elif PLATFORM(IOS) > > Probably (?) could get rid of this ifdef Good point. If we want to do compile time optimization we can do that in Device.h/cpp instead of here. Will do. Committed r283721 (242645@main): <https://commits.webkit.org/242645@main> |