Bug 231327 – Rewrite LayoutTests/plugins/object-onfocus-mutation-crash.html to stop relying on autofocus

• Component: DOM
• Status: RESOLVED FIXED

[Tim Nguyen (:ntim)]

This test mostly tests onfocus and <object>, we don't need it to use autofocus. The new autofocus timing will be async so we don't want this test to break with the new autofocus behavior implemented.

[Tim Nguyen (:ntim)]

See also bug 231219 for similar changes in other tests.

[Tim Nguyen (:ntim)]

Created attachment 440428 [details]
Patch

[Chris Dumez]

Comment on attachment 440428 [details]
Patch

This seems to completely disable the test. This test was introduced to cover a code change in HTMLObjectElement/HTMLPlugInImageElement and it is no longer covered since you're dropping the object element..

[Chris Dumez]

Comment on attachment 440428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440428&action=review

> LayoutTests/plugins/object-onfocus-mutation-crash.html:4
> +<object data="a">

Oh, I misread. You merely moved the <object>

> LayoutTests/plugins/object-onfocus-mutation-crash.html:22
> +    finish();

Any reason we can't keep calling finish asynchronously?

[Tim Nguyen (:ntim)]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 440428 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440428&action=review
> 
> > LayoutTests/plugins/object-onfocus-mutation-crash.html:4
> > +<object data="a">
> 
> Oh, I misread. You merely moved the <object>
> 
> > LayoutTests/plugins/object-onfocus-mutation-crash.html:22
> > +    finish();
> 
> Any reason we can't keep calling finish asynchronously?

No reason, just looks cleaner without the setTimeout, but I can add it back.

[Tim Nguyen (:ntim)]

Created attachment 440434 [details]
[fast-cq] Patch

[Tim Nguyen (:ntim)]

Committed r283657 (242602@main): <https://commits.webkit.org/242602@main>

[Radar WebKit Bug Importer]

<rdar://problem/83950034>