Summary: | Rewrite LayoutTests/plugins/object-onfocus-mutation-crash.html to stop relying on autofocus | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||
Component: | DOM | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 203139 | ||||||||
Attachments: |
|
Description
Tim Nguyen (:ntim)
2021-10-06 13:21:01 PDT
See also bug 231219 for similar changes in other tests. Created attachment 440428 [details]
Patch
Comment on attachment 440428 [details]
Patch
This seems to completely disable the test. This test was introduced to cover a code change in HTMLObjectElement/HTMLPlugInImageElement and it is no longer covered since you're dropping the object element..
Comment on attachment 440428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440428&action=review > LayoutTests/plugins/object-onfocus-mutation-crash.html:4 > +<object data="a"> Oh, I misread. You merely moved the <object> > LayoutTests/plugins/object-onfocus-mutation-crash.html:22 > + finish(); Any reason we can't keep calling finish asynchronously? (In reply to Chris Dumez from comment #4) > Comment on attachment 440428 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440428&action=review > > > LayoutTests/plugins/object-onfocus-mutation-crash.html:4 > > +<object data="a"> > > Oh, I misread. You merely moved the <object> > > > LayoutTests/plugins/object-onfocus-mutation-crash.html:22 > > + finish(); > > Any reason we can't keep calling finish asynchronously? No reason, just looks cleaner without the setTimeout, but I can add it back. Created attachment 440434 [details]
[fast-cq] Patch
Committed r283657 (242602@main): <https://commits.webkit.org/242602@main> |