Bug 231326

Summary: Delete WebCore::DisplayList::SetInlineFillGradient
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230860    
Attachments:
Description Flags
For EWS
none
For EWS none

Wenson Hsieh
Reported 2021-10-06 13:18:39 PDT
This display list item was originally introduced to allow Canvas Lines to run to fully run without using any out-of-line display list items, when using Concurrent Display Lists. However, the way this item is currently being encoded is not safe, since Gradient::Data is a Variant. I did not measure use of this display list item to affect performance of Canvas Lines in the streaming display list prototype, so instead of making it work with the new architecture, we should just delete it altogether.
Attachments
For EWS (16.45 KB, patch)
2021-10-06 13:22 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (16.81 KB, patch)
2021-10-06 15:38 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-10-06 13:22:02 PDT
Created attachment 440426 [details] For EWS
Simon Fraser (smfr)
Comment 2 2021-10-06 14:22:34 PDT
Comment on attachment 440426 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=440426&action=review > Source/WebCore/ChangeLog:10 > + - It should never have been encoded and decoded as POD data in the first place, due to the fact that it weird flex but ok
Wenson Hsieh
Comment 3 2021-10-06 15:35:57 PDT
Comment on attachment 440426 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=440426&action=review Oops, looks like I missed a spot when splitting this patch out, where we still look for `GraphicsContextState::FillGradientChange` in `containsOnlyInlineStateChanges`. This should fix the failing tests in mac-wk2 >> Source/WebCore/ChangeLog:10 >> + - It should never have been encoded and decoded as POD data in the first place, due to the fact that it > > weird flex but ok 😅
Wenson Hsieh
Comment 4 2021-10-06 15:38:29 PDT
Created attachment 440445 [details] For EWS
EWS
Comment 5 2021-10-06 19:22:56 PDT
Committed r283697 (242623@main): <https://commits.webkit.org/242623@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440445 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-06 19:23:23 PDT
<rdar://problem/83963203>
Note You need to log in before you can comment on or make changes to this bug.