Bug 231318

Summary: Remove "using namespace XPath;" from XPathGrammar.cpp
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch cdumez: review+, ews-feeder: commit-queue-

Alex Christensen
Reported 2021-10-06 12:10:23 PDT
Remove "using namespace XPath;" from XPathGrammar.cpp
Attachments
Patch (75.06 KB, patch)
2021-10-06 12:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (73.42 KB, patch)
2021-10-06 13:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (74.93 KB, patch)
2021-10-06 13:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (73.02 KB, patch)
2021-10-06 13:26 PDT, Alex Christensen 		cdumez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-06 12:11:37 PDT
Created attachment 440408 [details] Patch
Darin Adler
Comment 2 2021-10-06 12:58:16 PDT
Oh, got it. Didn’t know we had checked in the yacc output! Sorry for trouble I caused while "helping".
Alex Christensen
Comment 3 2021-10-06 13:04:54 PDT
Created attachment 440422 [details] Patch
Darin Adler
Comment 4 2021-10-06 13:23:10 PDT
Comment on attachment 440422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440422&action=review > Source/WebCore/xml/XPathGrammar.cpp:-2160 > - IGNORE_CLANG_WARNINGS_BEGIN("unreachable-code") > if (/*CONSTCOND*/ 0) > goto yyerrorlab; > - IGNORE_CLANG_WARNINGS_END I think we need to re-add this change? Since it’s a WebKit-specific macro, it’s unlikely this was generated by Bison.
Alex Christensen
Comment 5 2021-10-06 13:25:31 PDT
Created attachment 440429 [details] Patch
Alex Christensen
Comment 6 2021-10-06 13:26:13 PDT
Created attachment 440430 [details] Patch
Darin Adler
Comment 7 2021-10-06 14:00:13 PDT
Comment on attachment 440430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440430&action=review > Source/WebCore/ChangeLog:9 > + I did this by editing XPathGrammar.y and re-running bison. > + We have the output of bison checked in to our repo to not have bison as a build dependency of WebKit. Maybe we should record that "ignore warnings" step somewhere
Alex Christensen
Comment 8 2021-10-06 17:27:05 PDT
I'm not sure if the ignore warnings step is still needed. It seems to have built fine without it.
Darin Adler
Comment 9 2021-10-06 18:12:23 PDT
(In reply to Alex Christensen from comment #8) > I'm not sure if the ignore warnings step is still needed. It seems to have > built fine without it. Could use git to research when it was done, by who, to see if that makes logical sense.
Alex Christensen
Comment 10 2021-10-11 07:13:42 PDT
Apparently I added the original pragma that ignored that warning in https://trac.webkit.org/changeset/209883/webkit and I don't remember why. Perhaps it was to make EWS green. EWS is green now so I don't think it's needed any more.
Radar WebKit Bug Importer
Comment 11 2021-10-13 12:11:17 PDT
<rdar://problem/84210320>
EWS
Comment 12 2021-10-18 16:46:07 PDT
commit-queue failed to commit attachment 440430 [details] to WebKit repository. To retry, please set cq+ flag again.
Alex Christensen
Comment 13 2021-10-18 17:49:51 PDT
I used svn to allow tabs rather than rewrite the generated source. http://trac.webkit.org/r284420
Note You need to log in before you can comment on or make changes to this bug.