Bug 231316

Summary:

Regression (r281291): [ iOS 15 ] fast/text/accessibility-bold-system-font-2.html is image failing

Product:

WebKit

Reporter:

ayumi_kojima

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

NEW

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, ap, bfulgham, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, mmaxfield, samuel_white, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
image diff	none
Patch	none

ayumi_kojima

Reported 2021-10-06 11:44:46 PDT

fast/text/accessibility-bold-system-font-2.html Is constantly image failing on iOS 15 Debug and flaky (very flaky) image failing on iOS 15 Release. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext%2Faccessibility-bold-system-font-2.html According to the history, it started failing after updating to iOS 15.

Attachments
image diff (12.68 KB, image/png) 2021-10-06 11:45 PDT, ayumi_kojima	no flags	Details
Patch (10.24 KB, patch) 2022-04-13 00:28 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

ayumi_kojima

Comment 1 2021-10-06 11:45:06 PDT

Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r283612%20(72)/results.html

ayumi_kojima

Comment 2 2021-10-06 11:45:36 PDT

Created attachment 440398 [details] image diff

Radar WebKit Bug Importer

Comment 3 2021-10-06 11:45:58 PDT

<rdar://problem/83944188>

ayumi_kojima

Comment 4 2021-10-06 11:50:10 PDT

Marked test expectations https://trac.webkit.org/changeset/283642/webkit

ayumi_kojima

Comment 5 2021-10-06 11:55:05 PDT

I was able to reproduce the image failure locally on iOS 15 sim using run-webkit-tests --force --debug --ios-simulator fast/text/accessibility-bold-system-font-2.html

ayumi_kojima

Comment 6 2021-10-06 13:56:43 PDT

As I was bisecting, the test failed on r281291 and newer but passed on r281290 and older.

Myles C. Maxfield

Comment 7 2022-04-13 00:28:21 PDT

Created attachment 457510 [details] Patch

Darin Adler

Comment 8 2022-04-18 17:29:52 PDT

Comment on attachment 457510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457510&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:392 > - auto& after = keyframes[i]; > + auto& after = keyframes[i + 1]; Great fix, but not mentioned in the change log. Do we have test coverage? > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:417 > - auto& after = keyframes[i]; > + auto& after = keyframes[i + 1]; Ditto.

Myles C. Maxfield

Comment 9 2022-04-18 22:29:07 PDT

Comment on attachment 457510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457510&action=review >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:392 >> + auto& after = keyframes[i + 1]; > > Great fix, but not mentioned in the change log. Do we have test coverage? This patch is not marked for review 🤔 We do; I’m handling it in https://bugs.webkit.org/show_bug.cgi?id=239374. That bug has a big chain of blocking bugs because I’m trying to figure out a performance regression, and I’m lumping in the fix in with that effort.

Brent Fulgham

Comment 10 2022-06-23 14:29:50 PDT

This actually seems to be tracked by: rdar://88249241.

Note You need to log in before you can comment on or make changes to this bug.