Bug 231310

Summary: [webkitscmpy] Library should own contributors.json loading
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229690
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-10-06 10:45:33 PDT
In preparation for integrating GitHub usernames, webkitscmpy should own the loading of contributors.json.
Attachments
Patch (11.56 KB, patch)
2021-10-06 13:27 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.88 KB, patch)
2021-10-07 16:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-06 10:46:11 PDT
<rdar://problem/83941327>
Jonathan Bedard
Comment 2 2021-10-06 13:27:11 PDT
Created attachment 440431 [details] Patch
dewei_zhu
Comment 3 2021-10-07 14:52:37 PDT
Comment on attachment 440431 [details] Patch r=me
Jonathan Bedard
Comment 4 2021-10-07 16:08:16 PDT
Created attachment 440551 [details] Patch for landing
EWS
Comment 5 2021-10-07 16:45:15 PDT
Committed r283758 (242679@main): <https://commits.webkit.org/242679@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440551 [details].
Jonathan Bedard
Comment 6 2021-10-07 17:09:56 PDT
Committed r283759 (242680@main): <https://commits.webkit.org/242680@main>
Note You need to log in before you can comment on or make changes to this bug.