| Summary: | Misuses of pango_coverage_get and pango_coverage_from_bytes. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hiroyuki Ikezoe <poincare> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Hiroyuki Ikezoe
2009-01-05 19:27:14 PST
Created attachment 26449 [details]
Proposed patch
It looks right, is there any way to test it? Comment on attachment 26449 [details] Proposed patch > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 39635) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2009-01-05 Hiroyuki Ikezoe <poincare@ikezoe.net> > + > + Reviewed by NOBODY (OOPS!). > + > + Invoke pango_coverage_get with each Unicode character. please don't use tabs. Could you please also tell me what is broken with the other way of doing it? How you spotted it? (In reply to comment #2) > It looks right, is there any way to test it? Unfortunately no. I found the issue when I read the code to solve bug #18546. Actually I can not reproduce bug #18546, so I *just* read the code. Created attachment 26517 [details]
expand tabs in ChangeLog.
Comment on attachment 26517 [details]
expand tabs in ChangeLog.
You shouldn't set r=+ yourself. :)
|