Bug 23127

Summary: Misuses of pango_coverage_get and pango_coverage_from_bytes.
Product: WebKit Reporter: Hiroyuki Ikezoe <poincare>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Description Flags
Proposed patch
zecke: review+
expand tabs in ChangeLog. poincare: review+

Description Hiroyuki Ikezoe 2009-01-05 19:27:14 PST
The second argument of pango_coverage_get should be a Unicode character.

The first argument of pango_coverage_from_bytes should be binary data generated from pango_coverage_to_bytes.
Comment 1 Hiroyuki Ikezoe 2009-01-05 19:34:39 PST
Created attachment 26449 [details]
Proposed patch
Comment 2 Holger Freyther 2009-01-07 16:34:54 PST
It looks right, is there any way to test it?
Comment 3 Holger Freyther 2009-01-07 16:48:24 PST
Comment on attachment 26449 [details]
Proposed patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 39635)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +2009-01-05  Hiroyuki Ikezoe  <poincare@ikezoe.net>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Invoke pango_coverage_get with each Unicode character.

please don't use tabs. Could you please also tell me what is broken with the other way of doing it? How you spotted it?
Comment 4 Hiroyuki Ikezoe 2009-01-07 18:02:34 PST
(In reply to comment #2)
> It looks right, is there any way to test it?

Unfortunately no.
I found the issue when I read the code to solve bug #18546.  Actually I can not reproduce bug #18546, so I *just* read the code.
Comment 5 Hiroyuki Ikezoe 2009-01-07 18:05:19 PST
Created attachment 26517 [details]
expand tabs in ChangeLog.
Comment 6 Holger Freyther 2009-01-08 03:50:07 PST
Comment on attachment 26517 [details]
expand tabs in ChangeLog.

You shouldn't set r=+ yourself. :)
Comment 7 Holger Freyther 2009-01-08 04:34:20 PST
Landed in r39701. Let us see how this is working out.