Bug 231250

Summary: FileSystemHandle should be ContextDestructionObserver
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231706    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Sihui Liu
Reported 2021-10-05 13:51:00 PDT
Same as FileSystemSyncAccessHandle.
Attachments
Patch (30.54 KB, patch)
2021-10-25 10:32 PDT, Sihui Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (30.70 KB, patch)
2021-10-25 10:38 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.72 KB, patch)
2021-10-26 14:11 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-12 13:51:18 PDT
<rdar://problem/84164797>
Sihui Liu
Comment 2 2021-10-25 10:32:24 PDT
Created attachment 442383 [details] Patch
Sihui Liu
Comment 3 2021-10-25 10:38:22 PDT
Created attachment 442384 [details] Patch
youenn fablet
Comment 4 2021-10-26 02:03:02 PDT
Comment on attachment 442384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442384&action=review > Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h:57 > + FileSystemHandle(ScriptExecutionContext*, Kind, String&& name, FileSystemHandleIdentifier, Ref<FileSystemStorageConnection>&&); We usually go with ScriptExecutionContext& > Source/WebCore/Modules/storage/StorageManager.cpp:122 > + auto* context = weakNavgiator ? weakNavgiator->scriptExecutionContext() : nullptr; s/weakNavgiator/weakNavigator
Sihui Liu
Comment 5 2021-10-26 14:11:38 PDT
Created attachment 442528 [details] Patch for landing
EWS
Comment 6 2021-10-26 14:42:15 PDT
Committed r284900 (243577@main): <https://commits.webkit.org/243577@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442528 [details].
Note You need to log in before you can comment on or make changes to this bug.