Bug 231250

Summary: FileSystemHandle should be ContextDestructionObserver
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231706    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Description Sihui Liu 2021-10-05 13:51:00 PDT 
Same as FileSystemSyncAccessHandle.
Comment 1 Radar WebKit Bug Importer 2021-10-12 13:51:18 PDT 
<rdar://problem/84164797>
Comment 2 Sihui Liu 2021-10-25 10:32:24 PDT 
Created attachment 442383 [details]
Patch
Comment 3 Sihui Liu 2021-10-25 10:38:22 PDT 
Created attachment 442384 [details]
Patch
Comment 4 youenn fablet 2021-10-26 02:03:02 PDT 
Comment on attachment 442384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442384&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h:57
> +    FileSystemHandle(ScriptExecutionContext*, Kind, String&& name, FileSystemHandleIdentifier, Ref<FileSystemStorageConnection>&&);

We usually go with ScriptExecutionContext&

> Source/WebCore/Modules/storage/StorageManager.cpp:122
> +        auto* context = weakNavgiator ? weakNavgiator->scriptExecutionContext() : nullptr;

s/weakNavgiator/weakNavigator
Comment 5 Sihui Liu 2021-10-26 14:11:38 PDT 
Created attachment 442528 [details]
Patch for landing
Comment 6 EWS 2021-10-26 14:42:15 PDT 
Committed r284900 (243577@main): <https://commits.webkit.org/243577@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442528 [details].