Bug 231239

Summary: Prepare to switch from WTF::Variant to std::variant
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, darin, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, msaboff, pangle, philipj, pnormand, saam, samuel_white, sergio, tommyw, tzagallo, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-10-05 10:18:54 PDT
Prepare to switch from WTF::Variant to std::variant
Attachments
Patch (77.47 KB, patch)
2021-10-05 10:26 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (77.47 KB, patch)
2021-10-05 10:56 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (77.28 KB, patch)
2021-10-05 12:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (72.36 KB, patch)
2021-10-05 15:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-05 10:26:48 PDT
Created attachment 440232 [details] Patch
Alex Christensen
Comment 2 2021-10-05 10:56:43 PDT
Created attachment 440236 [details] Patch
Darin Adler
Comment 3 2021-10-05 11:19:26 PDT
Comment on attachment 440236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440236&action=review > Source/JavaScriptCore/runtime/CacheUpdate.cpp:41 > CacheUpdate::CacheUpdate(CacheUpdate&& other) Just had another idea for this. Can we try this? CacheUpdate::CacheUpdate(CacheUpdate&&) = default;
Darin Adler
Comment 4 2021-10-05 11:28:46 PDT
Comment on attachment 440236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440236&action=review >> Source/JavaScriptCore/runtime/CacheUpdate.cpp:41 >> CacheUpdate::CacheUpdate(CacheUpdate&& other) > > Just had another idea for this. Can we try this? > > CacheUpdate::CacheUpdate(CacheUpdate&&) = default; We could also experiment with removing the explicit move constructor and assignment operator from the class entirely. I am pretty sure the compiler will generate the correct code if we just don’t say anything.
Alex Christensen
Comment 5 2021-10-05 12:00:42 PDT
Created attachment 440243 [details] Patch
Alex Christensen
Comment 6 2021-10-05 12:13:01 PDT
Removing it causes compiler errors, but =default works fine.
Alex Christensen
Comment 7 2021-10-05 15:24:44 PDT
Created attachment 440279 [details] Patch
Xabier Rodríguez Calvar
Comment 8 2021-10-06 02:50:01 PDT
There are several appearances in for example CDMProxy.h and related files that are not being changed. In the GTK/WPE ports, these things are built when experimental features are enabled and I don't recall if we have them enabled in EWS so they won't fail. Anyway, I don't know if you're taking a step by step approach but those would need changing as well or things will break on our side.
Philippe Normand
Comment 9 2021-10-06 02:54:54 PDT
GTK/EWS developer builds have experimental features enabled.
EWS
Comment 10 2021-10-11 10:23:01 PDT
Committed r283906 (242780@main): <https://commits.webkit.org/242780@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440279 [details].
Radar WebKit Bug Importer
Comment 11 2021-10-11 10:24:32 PDT
<rdar://problem/84105079>
Note You need to log in before you can comment on or make changes to this bug.