Bug 231226

Summary: [css-grid] Recalculate grid's auto repeat columns when grid's relative width to its containing block width changes
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED INVALID    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rbuis, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

zsun
Reported 2021-10-05 04:13:46 PDT
We need to recalculate grid's auto repeat columns when the width/height of containing block changes. The grid has relative width/height to the containing block.
Attachments
Patch (4.00 KB, patch)
2021-10-05 04:21 PDT, zsun 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2021-10-05 06:23 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2021-10-08 06:30 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2021-10-11 03:13 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (3.93 KB, text/plain)
2021-10-11 05:15 PDT, zsun 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2021-10-05 04:21:22 PDT
Created attachment 440196 [details] Patch
zsun
Comment 2 2021-10-05 06:23:59 PDT
Created attachment 440205 [details] Patch
zsun
Comment 3 2021-10-08 06:30:57 PDT
Created attachment 440599 [details] Patch
Rob Buis
Comment 4 2021-10-08 06:53:34 PDT
Comment on attachment 440599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440599&action=review > Source/WebCore/rendering/RenderBox.cpp:1099 > + return style().paddingStart().isPercentOrCalculated() || style().paddingEnd().isPercentOrCalculated() || (isRenderGrid() && hasRelativeLogicalWidth()) || (style().hasAspectRatio() && (hasRelativeLogicalHeight() || (isFlexItem() && hasStretchedLogicalHeight()))); If you make a RenderGrid::needsPreferredWidthsRecalculation you can get rid of the isRenderGrid check and keep this simpler.
zsun
Comment 5 2021-10-11 03:13:01 PDT
Created attachment 440770 [details] Patch
Rob Buis
Comment 6 2021-10-11 05:08:35 PDT
Comment on attachment 440770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440770&action=review > Source/WebCore/rendering/RenderGrid.h:209 > + bool needsPreferredWidthsRecalculation() const final; Nit: in WebKit we keep the member vars and methods separate. In this case the method should go directly below aspectRatioPrefersInline.
zsun
Comment 7 2021-10-11 05:15:13 PDT
Created attachment 440775 [details] Patch
Radar WebKit Bug Importer
Comment 8 2021-10-12 04:14:15 PDT
<rdar://problem/84141634>
zsun
Comment 9 2022-05-13 03:27:59 PDT
I recall that we had an internal discussion with Javier on this patch and the solution here was not ideal. Make the patch as obselete.
zsun
Comment 10 2024-11-04 02:15:09 PST
This is not valid any more.
Note You need to log in before you can comment on or make changes to this bug.