Bug 231201

Summary: [JSC] Update test262
Product: WebKit Reporter: Philip Chimento <philip.chimento>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, darin, keith_miller, mark.lam, ross.kirsling, saam, webkit-bug-importer, xan.lopez, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Second patch none

Philip Chimento
Reported 2021-10-04 17:55:30 PDT
[JSC] Update test262
Attachments
Patch (5.08 MB, patch)
2021-10-04 17:59 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Patch (5.23 MB, patch)
2021-10-06 10:54 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Patch (5.23 MB, patch)
2021-10-06 11:24 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Second patch (29.51 KB, patch)
2021-10-06 13:35 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philip Chimento
Comment 1 2021-10-04 17:59:31 PDT
Created attachment 440130 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2021-10-05 20:39:55 PDT
TIP: pass the flag '--suggest-reviewers' to webkit-patch so the tool automatically recommends the reviewers to CC. Otherwise the patch won't get noticed.
Philip Chimento
Comment 3 2021-10-06 10:54:42 PDT
Created attachment 440388 [details] Patch
Philip Chimento
Comment 4 2021-10-06 11:24:32 PDT
Created attachment 440394 [details] Patch
EWS
Comment 5 2021-10-06 13:20:55 PDT
Committed r283651 (242599@main): <https://commits.webkit.org/242599@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440394 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-06 13:22:14 PDT
<rdar://problem/83948851>
Philip Chimento
Comment 7 2021-10-06 13:35:15 PDT
Reopening to attach new patch.
Philip Chimento
Comment 8 2021-10-06 13:35:17 PDT
Created attachment 440433 [details] Second patch
Philip Chimento
Comment 9 2021-10-06 13:36:28 PDT
When I went to rebase my local branch I found that there were several tests that didn't make it in to the previous patch. Not sure what went wrong, I wonder if the patch was too long and they got cut off somehow! Here is a second patch with the remaining test262 tests.
EWS
Comment 10 2021-10-06 14:38:19 PDT
Committed r283666 (242606@main): <https://commits.webkit.org/242606@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440433 [details].
Note You need to log in before you can comment on or make changes to this bug.