Bug 23115

Summary: Create a version of ASSERT for use with otherwise unused variables
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Web Template FrameworkAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2009-01-05 01:51:25 PST
We have several ways to assert on otherwise unused variables, none of with is elegant enough: 1) if (!expr) ASSERT_NOT_REACHED(); 2) UNUSED_PARAM(); 3) #ifndef NDEBUG int result = #endif function(); ASSERT(!result) Darin suggested adding a macro just for this purpose that would combine ASSERT and UNUSED_PARAM.
Attachments
proposed patch (9.52 KB, patch)
2009-01-05 01:54 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-01-05 01:54:56 PST
Created attachment 26428 [details] proposed patch
Darin Adler
Comment 2 2009-01-05 07:23:20 PST
Comment on attachment 26428 [details] proposed patch This is great. I'm a little worried that the name, "ASSERT_UNUSED", will make people thing we're asserting that something is unused. But only a little worried, not a lot. r=me
Alexey Proskuryakov
Comment 3 2009-01-05 09:21:47 PST
Committed revision 39600.
Note You need to log in before you can comment on or make changes to this bug.