Summary: | JSValue* should be replaced with a class type. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Gavin Barraclough
2009-01-04 21:17:30 PST
Created attachment 26422 [details]
The patch
Testing on windows before setting review flag.
Created attachment 26443 [details]
With added 'doze jsc build fix goodness
Created attachment 26447 [details]
revert emitLoad function name change & fix typo in ChangeLog.
revert emitLoad name change & fix type in ChangeLog.
Comment on attachment 26447 [details] revert emitLoad function name change & fix typo in ChangeLog. > + value now encapsulaed it will likely make sense to migrate the functionality tyop Looks good, am only rubber stamping the rename portion of it, r=me on the JSValuePtr (and EncodedAsPtr) conversion logic, assuming you've tested jit + interpreter code paths, and perf is good Created attachment 26480 [details]
patch relative to 603, to test on windows [tot was broken earlier.]
Transmitting file data ......................................................................................................................................................................................................................................................................................................... Committed revision 39670. |