Bug 231042

Summary: Upgrade GCC requirement to 8.3.0
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Yusuke Suzuki
Reported 2021-09-30 15:57:16 PDT
Upgrade GCC requirement to 8.3.0
Attachments
Patch (3.21 KB, patch)
2021-09-30 15:58 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-09-30 15:58:51 PDT
Created attachment 439788 [details] Patch
Darin Adler
Comment 2 2021-09-30 17:03:21 PDT
Comment on attachment 439788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439788&action=review > Source/JavaScriptCore/runtime/ConfigFile.cpp:492 > #if COMPILER(GCC) > -#if GCC_VERSION_AT_LEAST(8, 0, 0) > IGNORE_WARNINGS_BEGIN("stringop-truncation") > -#endif > #endif IGNORE_GCC_WARNINGS_BEGIN > Source/JavaScriptCore/runtime/ConfigFile.cpp:496 > #if COMPILER(GCC) > -#if GCC_VERSION_AT_LEAST(8, 0, 0) > IGNORE_WARNINGS_END > -#endif > #endif IGNORE_GCC_WARNINGS_END > ChangeLog:9 > + Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian stable (buster) right now. > + This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields. Default initializers for bitfields!
Yusuke Suzuki
Comment 3 2021-09-30 17:23:13 PDT
Comment on attachment 439788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439788&action=review Thanks! >> Source/JavaScriptCore/runtime/ConfigFile.cpp:492 >> #endif > > IGNORE_GCC_WARNINGS_BEGIN That's nice! Changed. >> Source/JavaScriptCore/runtime/ConfigFile.cpp:496 >> #endif > > IGNORE_GCC_WARNINGS_END Ditto.
Yusuke Suzuki
Comment 4 2021-09-30 17:23:44 PDT
This only affects on GCC builders, and gtk / wpe are green. Landing.
Yusuke Suzuki
Comment 5 2021-09-30 17:26:37 PDT
Committed r283348 (242361@main): <https://commits.webkit.org/242361@main>
Radar WebKit Bug Importer
Comment 6 2021-09-30 17:27:17 PDT
<rdar://problem/83745622>
Note You need to log in before you can comment on or make changes to this bug.