Bug 231026

Summary: [macOS] Reduce sandbox telemetry
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2021-09-30 09:57:34 PDT 
Remove sandbox telemetry for resources that we already see are in use.
Comment 1 Per Arne Vollan 2021-09-30 09:58:21 PDT 
<rdar://83694937>
Comment 2 Per Arne Vollan 2021-09-30 10:20:42 PDT 
Created attachment 439753 [details]
Patch
Comment 3 Brent Fulgham 2021-09-30 10:34:41 PDT 
Comment on attachment 439753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439753&action=review

r=me, but double-check that '/tmp' versus '/var' thing.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:79
>      (literal "/var")

You remove '/tmp' here, but you give a specific rule for '/var' above. Which one is right?
Comment 4 Per Arne Vollan 2021-09-30 10:40:33 PDT 
Created attachment 439757 [details]
Patch
Comment 5 Per Arne Vollan 2021-09-30 10:41:38 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 439753 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439753&action=review
> 
> r=me, but double-check that '/tmp' versus '/var' thing.
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:79
> >      (literal "/var")
> 
> You remove '/tmp' here, but you give a specific rule for '/var' above. Which
> one is right?

Ah, good catch! I will fix.

Thanks for reviewing!
Comment 6 EWS 2021-09-30 12:53:34 PDT 
Committed r283323 (242348@main): <https://commits.webkit.org/242348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439757 [details].