Bug 231024

Summary: Regressions (r283288): [ macOS Debug ] webgl/2.0.0/conformance/state/gl-object-get-calls.html is timing out
Product: WebKit Reporter: ayumi_kojima
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, keith_miller, kkinnunen, mark.lam, msaboff, saam, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description ayumi_kojima 2021-09-30 09:46:18 PDT 
webgl/2.0.0/conformance/state/gl-object-get-calls.html

Is timing out on macOS Debug.

History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fstate%2Fgl-object-get-calls.html

Result page: https://build.webkit.org/results/Apple-BigSur-Debug-WK2-Tests/r283294%20(4003)/results.html

Diff:

No diff

The test has been timing out on GPU process for a while (Bug 222722).
Comment 1 Radar WebKit Bug Importer 2021-09-30 09:46:37 PDT 
<rdar://problem/83723856>
Comment 2 ayumi_kojima 2021-09-30 09:47:32 PDT 
webgl/2.0.0/conformance/ogles/GL/atan/atan_009_to_012.html might have the same root cause since this test recently started timing out on macOS Debug.

History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fogles%2FGL%2Fatan%2Fatan_009_to_012.html
Comment 3 ayumi_kojima 2021-09-30 11:46:24 PDT 
I was able to reproduce the timeout with run-webkit-tests --debug webgl/2.0.0/conformance/state/gl-object-get-calls.html with revisions before r283288, but the test passed with r283287 and after.

Tested with r283211 just to make sure because there is one off timeout in the history on BigSur wk2 Debug at r283211, but the test didn't time out locally.
Comment 4 Saam Barati 2021-09-30 14:13:47 PDT 
Created attachment 439779 [details]
patch
Comment 5 Mark Lam 2021-09-30 14:17:06 PDT 
Comment on attachment 439779 [details]
patch

r=me
Comment 6 ayumi_kojima 2021-09-30 15:44:57 PDT 
(In reply to ayumi_kojima from comment #3)
> I was able to reproduce the timeout with run-webkit-tests --debug
> webgl/2.0.0/conformance/state/gl-object-get-calls.html with revisions before
> r283288, but the test passed with r283287 and after.
> 
> Tested with r283211 just to make sure because there is one off timeout in
> the history on BigSur wk2 Debug at r283211, but the test didn't time out
> locally.

Came back to this bug and read my comment again and thought it was confusing. I meant r283288 and newer reproduced but r283287 and older didn't reproduce. It doesn't matter any more but thought I should clarify.
Comment 7 EWS 2021-09-30 16:06:28 PDT 
Committed r283344 (242359@main): <https://commits.webkit.org/242359@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439779 [details].
Comment 8 ayumi_kojima 2021-10-22 15:22:08 PDT 
Confirmed the test is passing now. 

Constant timeout on Catalina gpuprocess is not related to this change. It has been tracked in https://bugs.webkit.org/show_bug.cgi?id=222722