Bug 231022 – Regression (r283238)[ MacOS wk1 ] fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is timing out

• Component: Media
• Status: RESOLVED FIXED

fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html

Is timing out on macOS wk1.

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-webgl-events.html

Diff:

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-actual.txt
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 Exercises the potential events on CanvasCaptureMediaStream.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -9,8 +10,4 @@
 PASS Plugged stream to video tag.
 PASS Drawing to canvas.
 PASS Video play callback succeeded.
-PASS Video canplaythrough callback succeeded.
-PASS successfullyParsed is true
 
-TEST COMPLETE
-

[Radar WebKit Bug Importer]

<rdar://problem/83722125>

I was able to reproduce the timeout using run-webkit-tests fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html -1

Test timed out with r283238 and passed with r283234. I was not able to test in-between because there are no revisions available to test.

[youenn fablet]

Probably https://trac.webkit.org/changeset/283238/webkit where WK2 impl is different from WK1.

[Kimmo Kinnunen]

*** Bug 230624 has been marked as a duplicate of this bug. ***

[Kimmo Kinnunen]

Created attachment 439836 [details]
Patch

[youenn fablet]

Comment on attachment 439836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439836&action=review

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h:81
> +

Unnecessary

> Source/WebCore/html/CanvasBase.h:146
> +    HashSet<CanvasDisplayBufferObserver*> m_displayBufferObservers;

Can we make these WeakHashSet by making CanvasDisplayBufferObserver a CanMakeWeakPtr<>?

> Source/WebCore/html/HTMLCanvasElement.cpp:1062
> +        // composited and thus doesn't need preparation. Unfortunately

I am not sure we have tests with detached canvas, that might be worth adding, and making sure we match the spec or other browsers.

[Kimmo Kinnunen]

Created attachment 439839 [details]
Patch

[EWS]

Committed r283489 (242462@main): <https://commits.webkit.org/242462@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439839 [details].